Repository navigation
Add a note to Web App with SQL Database sample on MS EULA - #42
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Python command omits Azure selection, and both READMEs contain incorrectly rooted documentation links.
3 open findings
What changed in this PR
Documents the SQL Server EULA requirement for both Azure SQL sample variants.
Changes:
- Adds one-time and profile-based EULA configuration instructions.
- Documents Docker and Docker Compose behavior.
| File | Description |
|---|---|
samples/web-app-sql-database/python/README.md |
Adds EULA setup guidance for Python users. |
samples/web-app-sql-database/dotnet/README.md |
Adds EULA setup guidance for .NET users. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Clarified instructions for starting the emulator with EULA acceptance. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README.md to use HTTPS and corrected formatting. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README to use proper Markdown syntax and added clarification on environment variable settings for the emulator. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
This PR fixes the issue #37 on the AKS Samples and Tutorials for LocalStack for Azure repository.
Fixes SMF-944
Changes
Add the following note to all the
READMEfiles of the Web App with SQL Database (Python, .NET) samples:Note
Each logical server you create runs a Microsoft SQL Server container, so you must accept the SQL Server End-User Licensing Agreement before the emulator provisions one.
Start the emulator with
MSSQL_ACCEPT_EULAset toY:Host variables prefixed with
LOCALSTACK_are forwarded to the emulator, so the container receivesMSSQL_ACCEPT_EULA=Y.To accept it once rather than on every start, add it to an environment profile in your
lstkconfig:A profile's values are injected into the container directly, so the
LOCALSTACK_prefix is not used here.lstkreads the firstconfig.tomlit finds, starting with./.lstk/config.tomlin the current directory and then$HOME/.config/lstk/config.toml.See Config file search order for the full list and Passing environment variables to the container for how profiles work.
If you start the emulator with the
dockerCLI or Docker Compose, setMSSQL_ACCEPT_EULA=Ydirectly in the container environment instead.Without it,
az sql server createfails with(EulaNotAccepted).