Skip to content

Add a note to Web App with SQL Database sample on MS EULA - #42

Merged
paolosalvatori merged 5 commits into
mainfrom
web-app-sql-db-note
Oct 14, 2026
Merged

paolosalvatori merged 5 commits into
mainfrom
web-app-sql-db-note

Conversation

@paolosalvatori

@paolosalvatori paolosalvatori commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

This PR fixes the issue #37 on the AKS Samples and Tutorials for LocalStack for Azure repository.

Fixes SMF-944

Changes

Add the following note to all the README files of the Web App with SQL Database (Python, .NET) samples:

Note

Each logical server you create runs a Microsoft SQL Server container, so you must accept the SQL Server End-User Licensing Agreement before the emulator provisions one.
Start the emulator with MSSQL_ACCEPT_EULA set to Y:

LOCALSTACK_MSSQL_ACCEPT_EULA=Y lstk start --type azure

Host variables prefixed with LOCALSTACK_ are forwarded to the emulator, so the container receives MSSQL_ACCEPT_EULA=Y.

To accept it once rather than on every start, add it to an environment profile in your lstk config:

[[containers]]
type = "azure"
tag  = "latest"
port = "4566"
env  = ["mssql"]

[env.mssql]
MSSQL_ACCEPT_EULA = "Y"

A profile's values are injected into the container directly, so the LOCALSTACK_ prefix is not used here.
lstk reads the first config.toml it finds, starting with ./.lstk/config.toml in the current directory and then $HOME/.config/lstk/config.toml.
See Config file search order for the full list and Passing environment variables to the container for how profiles work.

If you start the emulator with the docker CLI or Docker Compose, set MSSQL_ACCEPT_EULA=Y directly in the container environment instead.
Without it, az sql server create fails with (EulaNotAccepted).

Copilot AI balanced review requested due to automatic review settings October 14, 2026 13:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Python command omits Azure selection, and both READMEs contain incorrectly rooted documentation links.

3 open findings
What changed in this PR

Documents the SQL Server EULA requirement for both Azure SQL sample variants.

Changes:

  • Adds one-time and profile-based EULA configuration instructions.
  • Documents Docker and Docker Compose behavior.
File Description
samples/​web-app-sql-database/​python/​README.md Adds EULA setup guidance for Python users.
samples/​web-app-sql-database/​dotnet/​README.md Adds EULA setup guidance for .NET users.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread samples/web-app-sql-database/python/README.md Outdated
Comment thread samples/web-app-sql-database/dotnet/README.md Outdated
Comment thread samples/web-app-sql-database/python/README.md Outdated
paolosalvatori and others added 3 commits October 14, 2026 15:48
Clarified instructions for starting the emulator with EULA acceptance.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README.md to use HTTPS and corrected formatting.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README to use proper Markdown syntax and added clarification on environment variable settings for the emulator.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@paolosalvatori
paolosalvatori merged commit 5db79f2 into main Oct 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants