Skip to content

fix(benchmarks): restore SQLite performance gate #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cofin wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

fix(benchmarks): restore SQLite performance gate #640

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0739673
fix(benchmarks): restore sqlite performance gate
cofin Jul 11, 2026
a1334d7
perf(driver): streamline cached execution checks
cofin Jul 11, 2026
ac1f568
perf(parameters): cache coercion metadata
cofin Jul 11, 2026
c378aab
perf(schema): cache collection aliases
cofin Jul 11, 2026
bf0d351
perf(compiler): precompute dynamic commenter state
cofin Jul 11, 2026
7e629e8
perf(cache): use ordered mappings for LRU state
cofin Jul 11, 2026
795426d
perf(observability): avoid redundant event work
cofin Jul 11, 2026
9c0865f
perf(litestar): reduce request middleware work
cofin Jul 11, 2026
a697060
perf(builder): hoist static dialect lookups
cofin Jul 11, 2026
2c6857d
style: apply project formatting
cofin Jul 11, 2026
6f647ae
fix(types): satisfy optimized path checks
cofin Jul 11, 2026
b9213a1
fix(parameters): preserve mutable coercion semantics
cofin Jul 11, 2026
22ad8b5
revert: remove unproven hot-path optimizations
cofin Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions tools/scripts/bench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,15 +666,15 @@ def raw_sqlite_read_heavy() -> None:
def sqlspec_sqlite_initialization() -> None:
with tempfile.NamedTemporaryFile(suffix=".db") as tmp:
spec = SQLSpec()
config = SqliteConfig(database=tmp.name)
config = SqliteConfig(connection_config={"database": tmp.name})
with spec.provide_session(config) as session:
session.execute(CREATE_TEST_TABLE)


def sqlspec_sqlite_write_heavy() -> None:
with tempfile.NamedTemporaryFile(suffix=".db") as tmp:
spec = SQLSpec()
config = SqliteConfig(database=tmp.name)
config = SqliteConfig(connection_config={"database": tmp.name})
with spec.provide_session(config) as session:
session.execute(CREATE_TEST_TABLE)
# Use execute_many for bulk inserts
Expand All @@ -685,7 +685,7 @@ def sqlspec_sqlite_write_heavy() -> None:
def sqlspec_sqlite_read_heavy() -> None:
with tempfile.NamedTemporaryFile(suffix=".db") as tmp:
spec = SQLSpec()
config = SqliteConfig(database=tmp.name)
config = SqliteConfig(connection_config={"database": tmp.name})
with spec.provide_session(config) as session:
session.execute(CREATE_TEST_TABLE)
data: Sequence[tuple[str]] = [(f"value_{i}",) for i in range(ROWS_TO_INSERT)]
Expand Down Expand Up @@ -1369,7 +1369,7 @@ def sqlspec_sqlite_iterative_inserts() -> None:
"""Individual inserts in a loop - shows per-call overhead."""
with tempfile.NamedTemporaryFile(suffix=".db") as tmp:
spec = SQLSpec()
config = SqliteConfig(database=tmp.name)
config = SqliteConfig(connection_config={"database": tmp.name})
with spec.provide_session(config) as session:
session.execute(CREATE_TEST_TABLE)
for i in range(ROWS_TO_INSERT):
Expand Down Expand Up @@ -1417,7 +1417,7 @@ def sqlspec_sqlite_repeated_queries() -> None:
"""Repeated single-row queries - tests query cache effectiveness."""
with tempfile.NamedTemporaryFile(suffix=".db") as tmp:
spec = SQLSpec()
config = SqliteConfig(database=tmp.name)
config = SqliteConfig(connection_config={"database": tmp.name})
with spec.provide_session(config) as session:
session.execute(CREATE_TEST_TABLE)
data: Sequence[tuple[str]] = [(f"value_{i}",) for i in range(ROWS_TO_INSERT)]
Expand Down Expand Up @@ -2476,7 +2476,7 @@ def sqlspec_sqlite_dict_key_transform() -> None:
"""SELECT 10K rows with 10 columns, then transform keys to camelCase (sqlspec)."""
with tempfile.NamedTemporaryFile(suffix=".db") as tmp:
spec = SQLSpec()
config = SqliteConfig(database=tmp.name)
config = SqliteConfig(connection_config={"database": tmp.name})
with spec.provide_session(config) as session:
session.execute(CREATE_WIDE_TABLE)
data: Sequence[tuple[str, ...]] = [_generate_wide_row(i) for i in range(ROWS_TO_INSERT)]
Expand Down Expand Up @@ -2513,7 +2513,7 @@ def sqlspec_sqlite_schema_mapping() -> None:
"""SELECT 10K rows and map to TypedDict using schema_type= parameter."""
with tempfile.NamedTemporaryFile(suffix=".db") as tmp:
spec = SQLSpec()
config = SqliteConfig(database=tmp.name)
config = SqliteConfig(connection_config={"database": tmp.name})
with spec.provide_session(config) as session:
session.execute(CREATE_WIDE_TABLE)
data: Sequence[tuple[str, ...]] = [_generate_wide_row(i) for i in range(ROWS_TO_INSERT)]
Expand Down Expand Up @@ -2567,7 +2567,7 @@ def sqlspec_sqlite_complex_parameters() -> None:
"""INSERT rows with complex parameter types: UUID, datetime, JSON (sqlspec)."""
with tempfile.NamedTemporaryFile(suffix=".db") as tmp:
spec = SQLSpec()
config = SqliteConfig(database=tmp.name)
config = SqliteConfig(connection_config={"database": tmp.name})
with spec.provide_session(config) as session:
session.execute(CREATE_COMPLEX_TABLE)
data: Sequence[tuple[str, str, str]] = [_generate_complex_row(i) for i in range(ROWS_TO_INSERT)]
Expand Down Expand Up @@ -2598,7 +2598,7 @@ def sqlspec_sqlite_thin_path_stress() -> None:
stress_count = ROWS_TO_INSERT * 10
with tempfile.NamedTemporaryFile(suffix=".db") as tmp:
spec = SQLSpec()
config = SqliteConfig(database=tmp.name)
config = SqliteConfig(connection_config={"database": tmp.name})
with spec.provide_session(config) as session:
session.execute(CREATE_TEST_TABLE)
for i in range(stress_count):
Expand Down
Loading