fix(benchmarks): restore SQLite performance gate#640
Draft
cofin wants to merge 13 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
- Coverage 76.82% 76.81% -0.01%
==========================================
Files 473 473
Lines 66108 66108
Branches 9821 9815 -6
==========================================
- Hits 50785 50781 -4
Misses 12031 12031
- Partials 3292 3296 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
cofin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqliteConfig(connection_config=...)APImake bench-gate; before this fix, all SQLSpec SQLite scenarios errored during setupBenchmark result
The restored command runs successfully through measurement but exits nonzero because three existing thresholds fail:
Cumulative optimization review
Each row is a full
make bench-gaterun at the cumulative commit. Cells showraw / SQLSpec (adjacent SQLSpec delta).The parameter memoization proposal also failed a red regression for in-place mutation of the public coercion map and was removed. The proposed NumPy deserializer deduplication failed an existing direct-deserializer regression because that inline path is required when no decoder table is supplied; it was restored and is not claimed here.
Validation
uv run pytest tests/unit/utils/test_bench.py tests/unit/utils/test_bench_gate.py tests/unit/utils/test_bench_tuning.py tests/unit/utils/test_bench_subsystems.py -q— 22 passedmake lint— passed, including pre-commit, mypy, pyright, and slotscheckmake bench-gate— measurement completed; command exited nonzero on iterative-insert, write-heavy, and read-heavy thresholds as shown aboveThe final diff contains only the benchmark harness API update.