Skip to content

rose: don't warn on stray CALL_ACCEPTED/CLEAR_CONFIRMATION in state 3 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuba-moo merged 1 commit into from
Sep 11, 2026
Merged

rose: don't warn on stray CALL_ACCEPTED/CLEAR_CONFIRMATION in state 3 #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion net/rose/rose_in.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,18 @@ static int rose_state3_machine(struct sock *sk, struct sk_buff *skb, int framety
break;

default:
printk(KERN_WARNING "ROSE: unknown %02X in state 3\n", frametype);
/*
* CALL_ACCEPTED (0x0F) and CLEAR_CONFIRMATION (0x17) may show
* up in state 3 as a late or duplicated Call Accepted, or as
* crossed clearing / a reused logical channel on a slow AX.25
* link. These are harmless protocol races, so drop them
* silently. Any other frame type is genuinely unexpected and
* is still reported, rate limited to avoid flooding the log.
*/
if (frametype != ROSE_CALL_ACCEPTED &&
frametype != ROSE_CLEAR_CONFIRMATION)
net_warn_ratelimited("ROSE: unknown %02X in state 3\n",
frametype);
break;
}

Expand Down