rose: don't warn on stray CALL_ACCEPTED/CLEAR_CONFIRMATION in state 3 - #7
Open
f6bvp wants to merge 1 commit into
Open
rose: don't warn on stray CALL_ACCEPTED/CLEAR_CONFIRMATION in state 3#7f6bvp wants to merge 1 commit into
f6bvp wants to merge 1 commit into
Conversation
rose_state3_machine() logs "ROSE: unknown %02X in state 3" at
KERN_WARNING for any frame type it does not handle during data
transfer. Two of them reach that default arm routinely on real AX.25
links and alarm sysops watching the console, even though they are
harmless:
- CALL_ACCEPTED (0x0F): a late or duplicated Call Accepted that
arrives after the socket has already moved to STATE_3, typically a
retransmission on a slow link.
- CLEAR_CONFIRMATION (0x17): crossed clearing, or a clear confirmation
left over from a previous incarnation of a reused logical channel.
In both cases the frame is simply dropped: no state change, no
teardown, nothing freed. Only the noise is a problem.
Drop these two frame types silently. Keep reporting any other,
genuinely unexpected frame type, but through net_warn_ratelimited() so
a misbehaving peer cannot flood the kernel log.
Signed-off-by: Bernard Pidoux <bernard.f6bvp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rose_state3_machine() logs "ROSE: unknown %02X in state 3" at
KERN_WARNING for any frame type it does not handle during data
transfer. Two of them reach that default arm routinely on real AX.25
links and alarm sysops watching the console, even though they are
harmless:
CALL_ACCEPTED (0x0F): a late or duplicated Call Accepted that
arrives after the socket has already moved to STATE_3, typically a
retransmission on a slow link.
CLEAR_CONFIRMATION (0x17): crossed clearing, or a clear confirmation
left over from a previous incarnation of a reused logical channel.
In both cases the frame is simply dropped: no state change, no
teardown, nothing freed. Only the noise is a problem.
Fix: drop these two frame types silently. Keep reporting any other,
genuinely unexpected frame type, but through net_warn_ratelimited() so
a misbehaving peer cannot flood the kernel log.
Single commit, applies cleanly to current main.