fix(discover): keep HTTPS installers from vendor sites and add clear selection - #377
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a882723ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Test Results 1 351 files ±0 1 378 suites ±0 10m 27s ⏱️ +24s Results for commit 9338af7. ± Comparison against base commit bb41819. This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
linroid
changed the title
linroid
force-pushed
the
fix/discover-installer-filter
branch
from
October 4, 2026 09:27
45e4625 to
4567ff0
Compare
linroid
changed the title
linroid
added this pull request to stack #381
October 4, 2026 09:29
…selection DeviceSafetyFilter dropped every .exe/.msi/.dmg/.pkg/.apk whose host was not on a short built-in list, so official installers hosted on a vendor's own site vanished after the agent accepted them. Such installers are now scored down over HTTPS and blocked only without HTTPS; hosts that imitate a listed domain, and http(s) URLs with user info, are blocked for every file type. The Discover add bar gets a button that clears the whole selection, including results selected in earlier messages.
…ike block A host that contains a trusted domain but sits under the same site, such as archive-downloads.apache.org beside downloads.apache.org, belongs to the vendor, so it is no longer blocked as an impersonation.
linroid
force-pushed
the
fix/discover-installer-filter
branch
from
October 4, 2026 09:29
4567ff0 to
9338af7
Compare
…github.com/linroid/Ketch into HEAD # Conflicts: # app/shared/src/commonTest/kotlin/com/linroid/ketch/app/state/AiDiscoverControllerTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DeviceSafetyFilter): installers (.exe,.msi,.dmg,.pkg,.apk) from hosts off the built-in trusted list are no longer hard-blocked. Over HTTPS they are kept with a 0.2 score penalty, so they rank below the same file from a listed host. Without HTTPS they are still blocked.fake-github.com,github.com.example.net) and http(s) URLs carrying user info (github.com@evil.example). Other hosts of a trusted domain's own site, such asarchive-downloads.apache.org, are not treated as fakes.AiDiscoverController.clearSelection()). It reuses the existingdiscover_clear_selectionstring.Why
The agent accepted three official PureWriter installers hosted on
kuromi.drakeet.cn, but the filter dropped all three because that host isn't on the list. Most vendors host installers on their own domain, so the old rule hid nearly every official installer outside GitHub/SourceForge.The selection bar could say "1 from earlier" with no quick way to drop a pick that was far up the chat.
Notes for reviewers
Tests
DeviceSafetyFilterTest: unlisted HTTPS installer kept and scored below a trusted one, unlisted HTTP installer blocked, look-alike hosts and user info blocked, sibling hosts of a trusted site kept.AiDiscoverControllerTest:clearSelection()deselects results across turns.