feat(discover): let users turn off the content filter - #380
Merged
linroid merged 2 commits intoOct 4, 2026
Merged
Conversation
linroid
added this pull request to stack #381
October 4, 2026 09:29
linroid
force-pushed
the
feat/discover-content-filter
branch
from
October 4, 2026 09:29
45e4625 to
1a42bf0
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45e46259ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Adds [ai] contentFilter (on by default), a Content filter switch in Settings > Discover and --no-filter in the CLI. The engine counts the results the filter hid; a message shows "N hidden by the content filter" with a link to Discover settings, or says so in its No downloads found card.
…icks one The parser removed duplicates before checking them, so a clean copy behind one the filter blocks vanished. Each copy is now checked, the first that passes is kept, and a link counts as hidden only when no copy passes.
linroid
force-pushed
the
feat/discover-content-filter
branch
from
October 4, 2026 09:43
5124ab7 to
46cb7fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #377 (installer filter fix). Merge that first; this PR then retargets to
main.What
[ai] contentFilter(on by default) adds a Content filter switch to Settings → Discover, plus a settings-search entry. It travels with each search (DiscoverQuery.contentFilter) and is left out ofAiSettings.engineSettings, so changing it never rebuilds the engine.DiscoverResult.filtered), and each message saves the count in the history (DiscoverTurn.filtered). A message shows "N hidden by the content filter · Discover settings" under its results. When the filter hid everything, the No downloads found card says so and has a Discover settings button.contentFilter, adds--no-filter, and notes the hidden count on stderr.Why
When the filter hid every result, the chat showed the agent's "Found 3…" summary above "No downloads found", with no hint why and no way to see the results anyway.
Notes for reviewers
docs/ai-discovery.md(new "The content filter" section),cli/README.mdandAGENTS.md.discover-filteredanddiscover-all-filtered.Tests
AgentOutputParserTest: filtered results are counted; with the filter off they are kept but private addresses are still dropped.AiSettingsTest,AiSettingsControllerTest: the setting defaults on, round-trips through TOML and keeps the provider.AiDiscoverControllerTest,DiscoverThreadItemsTest,DiscoverHistoryCodecTest: the setting is sent with each search, and the count is stored, saved, and shown as the line or the card.AiDiscoverArgsTest:--no-filter.