Skip to content

Fix inmemory odb backends. ObjectDatabase now has to create an empty odb…#1482

Open
Zoxive wants to merge 1 commit intolibgit2:masterfrom
Zoxive:zoxive/InMemoryErrorPossibleRegression
Open

Fix inmemory odb backends. ObjectDatabase now has to create an empty odb…#1482
Zoxive wants to merge 1 commit intolibgit2:masterfrom
Zoxive:zoxive/InMemoryErrorPossibleRegression

Conversation

@Zoxive
Copy link
Copy Markdown

@Zoxive Zoxive commented Aug 4, 2017

… and set it on the repository when it is inmemory.

Fixes #1479

… and set it on the repository when it is InMemory.
@Zoxive Zoxive force-pushed the zoxive/InMemoryErrorPossibleRegression branch from 60b8762 to 393c54a Compare August 4, 2017 13:05
@Zoxive
Copy link
Copy Markdown
Author

Zoxive commented Aug 7, 2017

Looks like the OSX build has been failing for a while? Everything else is good to go.

@bording
Copy link
Copy Markdown
Member

bording commented Aug 7, 2017

@Zoxive The Travis CI mac infrastructures tends to have what appear to be connectivity issues, and the builds fail because it can't restore packages. I've restarted the build and everything looks good now.

@Zoxive
Copy link
Copy Markdown
Author

Zoxive commented Nov 13, 2017

We will be going to production in December with these changes. (In a fork) Any reviews/comments would be appreciated to get this merged.

I also have the revived Pluggable RefDb to make once this is in. (Started by @ethomson 4 years ago) Zoxive@8efb8e9

@Zoxive
Copy link
Copy Markdown
Author

Zoxive commented Mar 12, 2018

Should I just combine both this and my Pluggable RefDb branch into one PR? What is easier for you guys?

@ethomson
Copy link
Copy Markdown
Member

Separate PRs is probably easier? We're sort of locked down for a release right now. I'd like to see libgit2 0.27 get out the door this week, and then get LibGit2Sharp 0.25 released immediately following (and using that). And then start merging PRs.

@pigalot
Copy link
Copy Markdown

pigalot commented May 11, 2018

Is there any update on this? Looks like 0.25 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants