Custom refdb backend support#1739
Open
sterlind wants to merge 26 commits intolibgit2:masterfrom
Open
Conversation
Author
|
It looks like AppVeyor failed with some build machine issue: Could a maintainer please rerun the check? |
…lic) return IntPtr. This is safe, since libgit2 disposes te handles after consuming them, and allocating the handles is the last thing the callbacks do, so no exceptions can cause leaks.
This reverts commit 529b618.
|
is there any hope this pr will be merged? |
|
@bording Is it possible for you to look at this? We utilitize the features this PR adds as well and have to maintain our own fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rewrite of zoxiv's refdb backend PR #1482 (their code here), since that targeted an ancient libgit2 with substantial API changes since then.
Changes due to libgit2:
foreachandforeach_globwere replaced with a newiteratorcallback in libgit2. Replaced them with a method that returnsIEnumerable<ReferenceData>.Other changes:
RefdbBackendExceptionsto signal errors, which simplifies the glue and lets native libgit2 error codes be returned.