cert-checker: Allow scraping pprof data#8833
Merged
Merged
Conversation
beautifulentropy
force-pushed
the
cert-checker-allow-scraping-pprof
branch
from
aebf135 to
b43c7a0
Compare
aarongable
previously approved these changes
Jul 1, 2026
aarongable
left a comment
aarongable
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo configuring the new debug addr in config-next.
Contributor
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
ezekiel
approved these changes
Jul 2, 2026
aarongable
approved these changes
Jul 3, 2026
aarongable
added a commit
that referenced
this pull request
Jul 6, 2026
This reverts PR #8606, which was merged as commit abfceb5. The revert is clean with the exception of one line in cmd/shell.go, as a result of the function signature change in #8833. We are reverting because automated analysis found several issues (mostly, but not all, minor) with the sweeping changes made in the slog PR. We will reland when the identified issues have been fixed. Part of #8557
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8829