Revert "Replace log package with fully slog-based system"#8853
Merged
Conversation
This reverts commit abfceb5.
aarongable
changed the title
jsha
approved these changes
Jul 6, 2026
jsha
left a comment
jsha
left a comment
Contributor
There was a problem hiding this comment.
I did a local git revert abfceb5f05ed9a3bac07762467d30ef43c37ead4 and got the same result (had to resolve a one-line merge conflict in func StatsAndLogging).
I'm surprised the revert was so clean - didn't we land some stuff that depended on the original PR?
Contributor
Author
|
I thought we had, but I was mistaken: the diff I was thinking of is in #8828, which hasn't landed yet. |
ezekiel
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts PR #8606, which was merged as commit abfceb5. The revert is clean with the exception of one line in cmd/shell.go, as a result of the function signature change in #8833.
We are reverting because automated analysis found several issues (mostly, but not all, minor) with the sweeping changes made in the slog PR. We will reland when the identified issues have been fixed.
Part of #8557