Repository navigation
Speedup Windows ROCm builds - #34
Merged
Merged
Conversation
Collaborator
Author
|
Bumping This change isn't needed upstream. Upstream already uses |
Member
|
IMO I would just mirror what upstream does. Redundancy is tech debt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows ROCm builds randomly took 2-4h even when the source hadn't changed.
Problem
clang.exea new modified time on every install, and with ccache's defaultcompiler_check=mtimethat makes every cache lookup miss.Fix
compiler_check=content(+ Ubuntu'ssloppinessflags) inwindows-rocm, matchingubuntu-24-rocm.rocm-wheelscache and now install ROCm every run, like Ubuntu. Costs ~1 min per job but frees ~3.3 GB of the repo's 10 GB cache quota, which we're currently over.ggml-org/ccache-actionfrom v1.2.16 to v1.2.21 (ccache 4.9 to 4.13), so each run's Summary page shows ccache hit/miss stats. The build logs are ~1.5 GB and get truncated, so the stats never show up there.Notes
ggml.h,common.cuh, etc.). Those force a full rebuild on both Windows and Ubuntu and will still take 2.5-4h.rocm-wheels-*-Windows-v2caches are no longer used and will age out on their own (or can be deleted manually).