Repository navigation
Use ccache depend mode for ROCm builds - #35
Merged
Merged
Conversation
Collaborator
Author
|
This PR and #34 are meant to go together.
|
superm1
approved these changes
Oct 25, 2026
Member
|
Make sure to send upstream too. |
Collaborator
Author
Upstream PR submitted and merged: ggml-org/llama.cpp#31231 Upstream is still on ROCm 10.0. PR that bumps ROCm to 10.1 is still open ggml-org/llama.cpp#30652. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ccachecould reuse old GPU code on ROCm 10.1.#if defined(RDNA3)) looks unchanged, and an object with the old GPU code is reused.mma.cuh, and 10.1 reused 69 cached objects in 5 min while 7.14 and 10.0 rebuilt them.ccacheversion changed, so nothing old can match.1a24df16 (b11846)toedc35384 (b11851), and changed GPU code. ROCm 7.14 and 10.0 recompiled correctly but 10.1 did not (it re-used stale GPU code).FIX
Turn on ccache
depend_modeinubuntu-24-rocmandwindows-rocmfor all ROCm versions. ccache then only reuses a result when the source file and every file the compiler says it read are unchanged, and never uses the second check.Notes
Preprocessed: 0(Ubuntu:Post ccachestep log; Windows: "CCache Statistics" on this PR's run Summary page).