Skip to content

security(connector): return validated identifiers to break JDBC taint edge #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lekhrocks merged 1 commit into from
Aug 7, 2026
Merged

security(connector): return validated identifiers to break JDBC taint edge #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions ...nnectors/src/main/java/com/syncflow/connector/metadata/AbstractJdbcMetadataConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public List<String> discoverSchemas(ConnectorContext ctx) {

@Override
public List<TableMetadata> fetchTables(ConnectorContext ctx, String schema) {
requireIdentifier(schema, "schema");
schema = requireIdentifier(schema, "schema");
ensureConnected(ctx);
var list = new ArrayList<TableMetadata>();
try {
Expand All @@ -126,8 +126,8 @@ schema, getStringOrNull(rs, "REMARKS"),

@Override
public List<ColumnMetadata> fetchColumns(ConnectorContext ctx, String schema, String table) {
requireIdentifier(schema, "schema");
requireIdentifier(table, "table");
schema = requireIdentifier(schema, "schema");
table = requireIdentifier(table, "table");
ensureConnected(ctx);
var cols = new ArrayList<ColumnMetadata>();
try {
Expand Down Expand Up @@ -158,8 +158,8 @@ public List<ColumnMetadata> fetchColumns(ConnectorContext ctx, String schema, St

@Override
public List<IndexMetadata> fetchIndexes(ConnectorContext ctx, String schema, String table) {
requireIdentifier(schema, "schema");
requireIdentifier(table, "table");
schema = requireIdentifier(schema, "schema");
table = requireIdentifier(table, "table");
ensureConnected(ctx);
var map = new LinkedHashMap<String, IndexMetadata>();
try {
Expand All @@ -184,8 +184,8 @@ public List<IndexMetadata> fetchIndexes(ConnectorContext ctx, String schema, Str

@Override
public PrimaryKeyMetadata fetchPrimaryKey(ConnectorContext ctx, String schema, String table) {
requireIdentifier(schema, "schema");
requireIdentifier(table, "table");
schema = requireIdentifier(schema, "schema");
table = requireIdentifier(table, "table");
ensureConnected(ctx);
var cols = new ArrayList<String>();
String name = null;
Expand All @@ -205,8 +205,8 @@ public PrimaryKeyMetadata fetchPrimaryKey(ConnectorContext ctx, String schema, S

@Override
public List<ForeignKeyMetadata> fetchForeignKeys(ConnectorContext ctx, String schema, String table) {
requireIdentifier(schema, "schema");
requireIdentifier(table, "table");
schema = requireIdentifier(schema, "schema");
table = requireIdentifier(table, "table");
ensureConnected(ctx);
var map = new LinkedHashMap<String, ForeignKeyMetadata.Builder>();
try {
Expand Down Expand Up @@ -272,16 +272,20 @@ protected Set<String> loadFkColumnNames(ConnectorContext ctx, String schema, Str
}

/**
* Reject caller-supplied schema/table values that aren't plain SQL
* identifiers. These reach JDBC metadata calls and connector queries, so a
* value like `users; DROP TABLE x` must never be passed through.
* Validate a caller-supplied schema/table value as a plain SQL identifier
* and return it. These reach JDBC metadata calls and connector queries, so
* a value like `users; DROP TABLE x` must never be passed through.
*
* Returning the value keeps the taint flow explicit: the value handed to
* the JDBC call is the validator's output, not the raw user input.
*/
protected void requireIdentifier(String value, String label) {
protected String requireIdentifier(String value, String label) {
if (value == null || value.isBlank()
|| !value.matches("[A-Za-z_][A-Za-z0-9_$]*")) {
throw new IllegalArgumentException(
"Invalid " + label + " identifier: '" + value + "'");
}
return value;
}

protected String getStringOrNull(ResultSet rs, String col) throws SQLException {
Expand Down
Loading