security(connector): return validated identifiers to break JDBC taint edge - #53
Merged
Conversation
… edge requireIdentifier now returns the validated value and each metadata method reassigns its schema/table parameter from it, so the value passed to JDBC metadata calls is the validator's output rather than the raw user input. This makes the sanitization explicit to static taint analysis (the previous void-guard wasn't visible to it) while preserving the same rejection rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #52 (already merged): make the JDBC metadata identifier guard visible to static taint analysis.
Change
AbstractJdbcMetadataConnector.requireIdentifiernow returns the validated identifier, and each metadata method reassigns itsschema/tableparameter from it (schema = requireIdentifier(schema, "schema")).Previously the guard only validated (void return), which a static taint scanner couldn't see through — it flagged the raw
schema/tableparameters flowing intoDatabaseMetaData.getPrimaryKeys/getColumns/etc. By rebinding the parameter to the validator's output, the value passed to the JDBC call is explicitly the sanitized value, not the user input. Same rejection rules:[A-Za-z_][A-Za-z0-9_$]*.Applied to all five JDBC-metadata methods:
fetchColumns,fetchTables,fetchIndexes,fetchPrimaryKey,fetchForeignKeys.Verification
./gradlew :syncflow-connectors:compileJavaclean./gradlew :syncflow-api:test :syncflow-connectors:testpass-Dtests.integration=true, Testcontainers) pass