feat: add free_sd_images function to manage memory for C API#1633
Open
Cyberhan123 wants to merge 1 commit into
Open
feat: add free_sd_images function to manage memory for C API#1633Cyberhan123 wants to merge 1 commit into
Cyberhan123 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a C-API helper to centralize deallocation of image buffers returned by the library, primarily to avoid Windows CRT mismatches when callers free memory allocated inside the DLL.
Changes:
- Added
free_sd_images(sd_image_t* result_images, int num_images)implementation to free per-image buffers plus the image array. - Exposed the new function in the public header with guidance for C API callers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/stable-diffusion.cpp | Implements free_sd_images to free image data buffers and the containing array. |
| include/stable-diffusion.h | Declares the new API and documents intended ownership/freeing pattern for C callers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is part of #1368.
This pull request introduces a new memory management function to the C API for handling image arrays, which is especially important for Windows compatibility. The main change is the addition of a
free_sd_imagesfunction to safely free memory allocated for image arrays, preventing issues related to mismatched C runtime libraries.Memory management improvements
free_sd_imagesto both thestable-diffusion.hheader and the implementation instable-diffusion.cpp. This function ensures that memory allocated for image arrays (sd_image_t*) is properly freed, addressing potential CRT (C Runtime) issues on Windows when memory is allocated in the library but freed in the caller.Checklist