feat: make ffi for same shap.#1635
Open
Cyberhan123 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the C/C++ upscaler API to return a pointer from upscale() and adjusts the CLI example to consume the new return type.
Changes:
- Changed
upscale()to returnsd_image_t*instead ofsd_image_tin the public header and implementation - Updated CLI example to dereference the returned
sd_image_t*when constructingSDImageOwner
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/upscaler.cpp | Changes upscale() implementation to return a pointer |
| include/stable-diffusion.h | Updates the exported API signature for upscale() |
| examples/cli/main.cpp | Adapts example usage to the new pointer return type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a supplement to the PR at #1633. The purpose is to ensure that the free image can correctly release all memory, so I think it is necessary to unify their return values into pointers.
Why do this?
Because we have a unified API for free images, but
upscaleis excluded as an exception.It was an optional PR, so I removed it and submitted it separately, but I felt it was necessary.
Checklist