Skip to content

Update opis/json-schema version constraint #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tacman wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Update opis/json-schema version constraint #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"nyholm/psr7": "^1.2",
"friendsofphp/php-cs-fixer": "^3.2.2",
"symfony/phpunit-bridge": "^6.0 || ^7.0 || ^8.0",
"opis/json-schema": "^1.0",
"opis/json-schema": "^1.0 || ^2.0",
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Widening the constraint to allow opis/json-schema v2 implicitly claims compatibility, but the repo has code paths (e.g., SchemaChecker/CheckerCommand used by bin/slack-api-client-generator) that call Opis\JsonSchema APIs and aren’t covered by CI/tests. Please either (a) add a CI step/matrix to exercise the checker command with v2 installed, or (b) keep the constraint on ^1.0 until compatibility with v2 is verified.

Suggested change
"opis/json-schema": "^1.0 || ^2.0",
"opis/json-schema": "^1.0",

Copilot uses AI. Check for mistakes.
"symfony/console": "^6.0 || ^7.0 || ^8.0",
"symfony/process": "^6.0 || ^7.0 || ^8.0"
},
Expand Down
Loading