Update opis/json-schema version constraint#190
Open
tacman wants to merge 1 commit intojolicode:mainfrom
Open
Conversation
resolve the version conflict with mcp/sdk.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dev dependency constraint for opis/json-schema to resolve a Composer version conflict with mcp/sdk.
Changes:
- Broaden
opis/json-schemainrequire-devfrom^1.0to^1.0 || ^2.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "friendsofphp/php-cs-fixer": "^3.2.2", | ||
| "symfony/phpunit-bridge": "^6.0 || ^7.0 || ^8.0", | ||
| "opis/json-schema": "^1.0", | ||
| "opis/json-schema": "^1.0 || ^2.0", |
There was a problem hiding this comment.
Widening the constraint to allow opis/json-schema v2 implicitly claims compatibility, but the repo has code paths (e.g., SchemaChecker/CheckerCommand used by bin/slack-api-client-generator) that call Opis\JsonSchema APIs and aren’t covered by CI/tests. Please either (a) add a CI step/matrix to exercise the checker command with v2 installed, or (b) keep the constraint on ^1.0 until compatibility with v2 is verified.
Suggested change
| "opis/json-schema": "^1.0 || ^2.0", | |
| "opis/json-schema": "^1.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve the version conflict with mcp/sdk.