[Fix] Pin LEAPP to 0.6.1 - #7592
Conversation
There was a problem hiding this comment.
Isaac Lab Review Bot
The change consistently excludes the known-broken LEAPP 0.7 release from the public optional extra and stabilizes the isaaclab_rl package-test job on the already resolved 0.6.0 release.
- Design and architecture: The compatibility bound is placed at the dependency declaration rather than worked around in export code. The corresponding lockfile package metadata and CI installation path were checked and are aligned with that decision.
- API: No Python, CLI, or configuration API changes. The externally visible dependency contract changes from
leapp>=0.5.2toleapp>=0.5.2,<0.7.0, preserving the existing supported range while excluding the reported incompatible release. No release-managed source package is changed. - Implementation: The
pyproject.tomlanduv.lockrequirement specifiers match, while CI explicitly installs LEAPP 0.6.0. The exact CI pin provides deterministic regression coverage, although it will not automatically exercise a future compatible 0.6.x patch release allowed by the public extra.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Greptile SummaryThis PR consistently excludes the regressed LEAPP 0.7 release while retaining LEAPP 0.6.0 as the resolved and CI-tested version.
Confidence Score: 5/5The PR appears safe to merge because its workflow pin, public dependency bound, and lockfile metadata are consistent. No actionable failure remains: CI and the lockfile select LEAPP 0.6.0, the public extra excludes the regressed 0.7 release, and no unrelated dependency resolution changes were introduced. Important Files Changed
Reviews (1): Last reviewed commit: "Pin LEAPP below 0.7" | Re-trigger Greptile |
|
run-ci |
|
run-ci |
Description
LEAPP 0.7.0 introduced two regressions in the Isaac Lab export suite after it was published on September 4:
robot_root_link_quat_wafter registering the aliased tensor asrobot_root_quat_w.BuiltinCallDesctuple subclasses duringwp.rand_initinterception.The
isaaclab_rlpackage-test job installed bareleapp, so the new release entered CI without a repository change. The same failures appeared in unrelated PRs, including #7585 and #7544.This change pins both the public
leappextra and the package-test installation toleapp==0.6.1. The lockfile now resolves the same version, keeping project environments and CI aligned until the LEAPP 0.7 regressions are fixed upstream.Type of change
Release backport
developScreenshots
Not applicable.
Validation
uv lock --checkpassed.uv run --extra leapp python -c "..."resolved and verified LEAPP 0.6.1.uv run isaaclab -fpassed every formatting, syntax, metadata, and spelling hook except the changelog-fragment hook. That hook reports four pre-existingdevelop-base fragment problems inisaaclab_newton,isaaclab_tasks,isaaclab_experimental, andisaaclab_visualizers; this PR changes nosource/path.git diff --check upstream/developpassed.Checklist
source/changes.CONTRIBUTORS.md.