Skip to content

[Fix] Pin LEAPP to 0.6.1 - #7592

Open
StafaH wants to merge 3 commits into
isaac-sim:developfrom
StafaH:fix/pin-leapp-below-0.7
Open

[Fix] Pin LEAPP to 0.6.1#7592
StafaH wants to merge 3 commits into
isaac-sim:developfrom
StafaH:fix/pin-leapp-below-0.7

Conversation

@StafaH

@StafaH StafaH commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Description

LEAPP 0.7.0 introduced two regressions in the Isaac Lab export suite after it was published on September 4:

  • Kuka-Allegro export re-enters the graph with robot_root_link_quat_w after registering the aliased tensor as robot_root_quat_w.
  • SKRL Cartpole export fails while LEAPP reconstructs Warp BuiltinCallDesc tuple subclasses during wp.rand_init interception.

The isaaclab_rl package-test job installed bare leapp, so the new release entered CI without a repository change. The same failures appeared in unrelated PRs, including #7585 and #7544.

This change pins both the public leapp extra and the package-test installation to leapp==0.6.1. The lockfile now resolves the same version, keeping project environments and CI aligned until the LEAPP 0.7 regressions are fixed upstream.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Release backport

  • Backport this pull request to the active release branch after it merges into develop

Screenshots

Not applicable.

Validation

  • uv lock --check passed.
  • uv run --extra leapp python -c "..." resolved and verified LEAPP 0.6.1.
  • Focused pre-commit YAML and TOML checks passed.
  • uv run isaaclab -f passed every formatting, syntax, metadata, and spelling hook except the changelog-fragment hook. That hook reports four pre-existing develop-base fragment problems in isaaclab_newton, isaaclab_tasks, isaaclab_experimental, and isaaclab_visualizers; this PR changes no source/ path.
  • git diff --check upstream/develop passed.

Checklist

  • I have read and understood the contribution guidelines.
  • I have run the pre-commit checks; the unrelated base-branch changelog failure is documented above.
  • Documentation changes are not required for this dependency pin.
  • My changes generate no new warnings.
  • No test was added; dependency resolution and repository metadata checks cover this pinning change.
  • No changelog fragment is required because no release-managed package under source/ changes.
  • My name already exists in CONTRIBUTORS.md.

@StafaH
StafaH requested a review from a team September 5, 2026 01:18
@github-actions github-actions Bot added bug Something isn't working infrastructure labels Sep 5, 2026

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The change consistently excludes the known-broken LEAPP 0.7 release from the public optional extra and stabilizes the isaaclab_rl package-test job on the already resolved 0.6.0 release.

  • Design and architecture: The compatibility bound is placed at the dependency declaration rather than worked around in export code. The corresponding lockfile package metadata and CI installation path were checked and are aligned with that decision.
  • API: No Python, CLI, or configuration API changes. The externally visible dependency contract changes from leapp>=0.5.2 to leapp>=0.5.2,<0.7.0, preserving the existing supported range while excluding the reported incompatible release. No release-managed source package is changed.
  • Implementation: The pyproject.toml and uv.lock requirement specifiers match, while CI explicitly installs LEAPP 0.6.0. The exact CI pin provides deterministic regression coverage, although it will not automatically exercise a future compatible 0.6.x patch release allowed by the public extra.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR consistently excludes the regressed LEAPP 0.7 release while retaining LEAPP 0.6.0 as the resolved and CI-tested version.

  • Adds an upper compatibility bound to the public leapp extra.
  • Pins the package-test job to LEAPP 0.6.0.
  • Synchronizes the lockfile’s optional-dependency metadata without changing its resolved packages.

Confidence Score: 5/5

The PR appears safe to merge because its workflow pin, public dependency bound, and lockfile metadata are consistent.

No actionable failure remains: CI and the lockfile select LEAPP 0.6.0, the public extra excludes the regressed 0.7 release, and no unrelated dependency resolution changes were introduced.

Important Files Changed

Filename Overview
.github/workflows/build.yaml Pins the Isaac Lab RL package-test installation to the known-good LEAPP 0.6.0 release.
pyproject.toml Constrains the public LEAPP optional dependency to versions from 0.5.2 through the 0.6 series.
uv.lock Mirrors the new LEAPP compatibility bound in package metadata while leaving the resolved LEAPP version unchanged.

Reviews (1): Last reviewed commit: "Pin LEAPP below 0.7" | Re-trigger Greptile

@StafaH StafaH changed the title [Fix] Pin LEAPP below 0.7 [Fix] Pin LEAPP to 0.6.1 Sep 5, 2026
@StafaH

StafaH commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Sep 5, 2026
@kellyguo11

Copy link
Copy Markdown
Contributor

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants