Refresh Franka Soft golden images for the PhysX and Newton renderer combination#6642
Conversation
…tion. The test case still needs to be disabled until we solve the hang.
79e8ad7 to
c5dc8cf
Compare
Greptile SummaryThis PR refreshes the Franka soft golden images for the PhysX and Newton renderer combination. The main changes are:
Confidence Score: 5/5The changed flow looks mergeable after confirming the intended scope of the PhysX skip.
source/isaaclab_tasks/test/rendering_test_utils.py Important Files Changed
Reviews (1): Last reviewed commit: "Refresh their golden images for the Phys..." | Re-trigger Greptile |
| if physics_backend == "physx" or renderer == "isaacsim_rtx_renderer": | ||
| pytest.skip("Random teardown hangs in the kit-based combinations (OMPE-101977).") |
There was a problem hiding this comment.
PhysX Gate Skips Refreshed Baselines
The new backend-wide condition also matches every physx + newton_renderer parameter, so none of the five newly refreshed Newton golden-image comparisons execute. If OMPE-101977 only requires disabling the Kit renderer paths, this condition silently removes the exact test coverage this change updates.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Yes. The other skip because Github Issue #3228 is removed such that it reflects the current code status. But the test case has to be skipped for now due to random hang which is another separate issue (OMPE-101977).
mmichelis
left a comment
There was a problem hiding this comment.
Necessary PR to get the CI running again. Thanks for looking further into this hanging issue Huidong!
Description
Refresh Franka Soft golden images for the PhysX and Newton renderer combination.
The test case still needs to be disabled until we solve the random hang on teardown of Kit-based combinations (OMPE-101977).
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there