Skip to content

Refresh Franka Soft golden images for the PhysX and Newton renderer combination#6642

Merged
huidongc merged 1 commit into
isaac-sim:developfrom
huidongc:newton-golden-image-update
Jul 21, 2026
Merged

Refresh Franka Soft golden images for the PhysX and Newton renderer combination#6642
huidongc merged 1 commit into
isaac-sim:developfrom
huidongc:newton-golden-image-update

Conversation

@huidongc

@huidongc huidongc commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Description

Refresh Franka Soft golden images for the PhysX and Newton renderer combination.

The test case still needs to be disabled until we solve the random hang on teardown of Kit-based combinations (OMPE-101977).

Type of change

  • Test data update

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@huidongc
huidongc requested a review from a team July 21, 2026 03:48
@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Jul 21, 2026
…tion.

The test case still needs to be disabled until we solve the hang.
@huidongc
huidongc force-pushed the newton-golden-image-update branch from 79e8ad7 to c5dc8cf Compare July 21, 2026 03:50
@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR refreshes the Franka soft golden images for the PhysX and Newton renderer combination. The main changes are:

  • Updated depth, normals, RGB, and RGBA reference images.
  • Added distance-to-camera and distance-to-image-plane references.
  • Changed the temporary skip condition for teardown hangs.
  • Added a test-only changelog entry.

Confidence Score: 5/5

The changed flow looks mergeable after confirming the intended scope of the PhysX skip.

  • The new predicate prevents every refreshed PhysX/Newton comparison from running.
  • This is harmless if the teardown hang applies to all PhysX cases in the Kit process.
  • If the hang only affects Kit renderers, the condition removes intended test coverage.

source/isaaclab_tasks/test/rendering_test_utils.py

Important Files Changed

Filename Overview
source/isaaclab_tasks/test/rendering_test_utils.py Broadens the teardown-hang skip to all PhysX cases, including the PhysX/Newton comparisons whose baselines are refreshed here.
source/isaaclab_tasks/test/golden_images/franka_soft/physx-newton_renderer-depth.png Refreshes the PhysX/Newton depth reference image.
source/isaaclab_tasks/test/golden_images/franka_soft/physx-newton_renderer-distance_to_camera.png Adds the PhysX/Newton distance-to-camera reference image.
source/isaaclab_tasks/test/golden_images/franka_soft/physx-newton_renderer-distance_to_image_plane.png Adds the PhysX/Newton distance-to-image-plane reference image.
source/isaaclab_tasks/test/golden_images/franka_soft/physx-newton_renderer-normals.png Refreshes the PhysX/Newton normals reference image.
source/isaaclab_tasks/test/golden_images/franka_soft/physx-newton_renderer-rgb.png Refreshes the PhysX/Newton RGB reference image.
source/isaaclab_tasks/test/golden_images/franka_soft/physx-newton_renderer-rgba.png Refreshes an RGBA reference that is not currently selected by the Newton renderer data-type matrix.

Reviews (1): Last reviewed commit: "Refresh their golden images for the Phys..." | Re-trigger Greptile

Comment on lines +1677 to +1678
if physics_backend == "physx" or renderer == "isaacsim_rtx_renderer":
pytest.skip("Random teardown hangs in the kit-based combinations (OMPE-101977).")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 PhysX Gate Skips Refreshed Baselines

The new backend-wide condition also matches every physx + newton_renderer parameter, so none of the five newly refreshed Newton golden-image comparisons execute. If OMPE-101977 only requires disabling the Kit renderer paths, this condition silently removes the exact test coverage this change updates.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The other skip because Github Issue #3228 is removed such that it reflects the current code status. But the test case has to be skipped for now due to random hang which is another separate issue (OMPE-101977).

@huidongc
huidongc requested a review from rilei-nvidia July 21, 2026 03:51

@rilei-nvidia rilei-nvidia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huidongc huidongc changed the title Refresh their golden images for the PhysX and Newton renderer combination Refresh Franka Soft golden images for the PhysX and Newton renderer combination Jul 21, 2026

@mmichelis mmichelis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary PR to get the CI running again. Thanks for looking further into this hanging issue Huidong!

@huidongc
huidongc merged commit bd4ec7d into isaac-sim:develop Jul 21, 2026
64 of 66 checks passed
@huidongc
huidongc deleted the newton-golden-image-update branch July 21, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants