Skip to content

Set PXR_WORK_THREAD_LIMIT=1 for kitless rendering correctness tests#6641

Open
mataylor-nvidia wants to merge 5 commits into
isaac-sim:developfrom
mataylor-nvidia:mataylor/kitless-pxr-thread-limit-one
Open

Set PXR_WORK_THREAD_LIMIT=1 for kitless rendering correctness tests#6641
mataylor-nvidia wants to merge 5 commits into
isaac-sim:developfrom
mataylor-nvidia:mataylor/kitless-pxr-thread-limit-one

Conversation

@mataylor-nvidia

Copy link
Copy Markdown

Limits OpenUSD's work-thread pool to a single thread for all kitless rendering tests to improve determinism in golden-image comparisons.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Limits OpenUSD's work-thread pool to a single thread for all kitless
rendering tests to improve determinism in golden-image comparisons.
@mataylor-nvidia
mataylor-nvidia requested a review from a team July 21, 2026 01:14
@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Jul 21, 2026
@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR limits OpenUSD worker concurrency for kitless rendering tests. The main change is:

  • Sets PXR_WORK_THREAD_LIMIT=1 in the shared autouse fixture before each rendering test.

Confidence Score: 5/5

This looks safe to merge.

  • The autouse fixture sets the worker limit before the test bodies perform their lazy rendering imports and initialize simulation state.
  • Pytest restores the previous environment value after each test.
  • No blocking issues were found in the changed code.

Important Files Changed

Filename Overview
source/isaaclab_tasks/test/rendering_test_utils.py Adds a function-scoped environment override before kitless tests initialize OpenUSD and simulation state.

Reviews (1): Last reviewed commit: "Set PXR_WORK_THREAD_LIMIT=1 for kitless ..." | Re-trigger Greptile


@pytest.fixture(autouse=True)
def _require_ovlibs_install(request, monkeypatch: pytest.MonkeyPatch):
monkeypatch.setenv("PXR_WORK_THREAD_LIMIT", "1")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an explanation a comment why this is here

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mataylor-nvidia can we add a TODO for when this can be removed? Do we expect a drop in start-up performance here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants