Set PXR_WORK_THREAD_LIMIT=1 for kitless rendering correctness tests#6641
Open
mataylor-nvidia wants to merge 5 commits into
Open
Set PXR_WORK_THREAD_LIMIT=1 for kitless rendering correctness tests#6641mataylor-nvidia wants to merge 5 commits into
mataylor-nvidia wants to merge 5 commits into
Conversation
Limits OpenUSD's work-thread pool to a single thread for all kitless rendering tests to improve determinism in golden-image comparisons.
mataylor-nvidia
requested review from
AntoineRichard,
StafaH,
kellyguo11 and
ooctipus
as code owners
July 21, 2026 01:14
Contributor
Greptile SummaryThis PR limits OpenUSD worker concurrency for kitless rendering tests. The main change is:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "Set PXR_WORK_THREAD_LIMIT=1 for kitless ..." | Re-trigger Greptile |
kellyguo11
approved these changes
Jul 21, 2026
pbarejko
reviewed
Jul 21, 2026
|
|
||
| @pytest.fixture(autouse=True) | ||
| def _require_ovlibs_install(request, monkeypatch: pytest.MonkeyPatch): | ||
| monkeypatch.setenv("PXR_WORK_THREAD_LIMIT", "1") |
Collaborator
There was a problem hiding this comment.
This needs an explanation a comment why this is here
Collaborator
There was a problem hiding this comment.
@mataylor-nvidia can we add a TODO for when this can be removed? Do we expect a drop in start-up performance here?
pbarejko
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limits OpenUSD's work-thread pool to a single thread for all kitless rendering tests to improve determinism in golden-image comparisons.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there