Skip to content

Cast torch tensors in ID resolvers to int32 before giving to warp kernel#6639

Open
angehu-nv wants to merge 1 commit into
isaac-sim:developfrom
angehu-nv:angehu/torch-int64-to-32
Open

Cast torch tensors in ID resolvers to int32 before giving to warp kernel#6639
angehu-nv wants to merge 1 commit into
isaac-sim:developfrom
angehu-nv:angehu/torch-int64-to-32

Conversation

@angehu-nv

Copy link
Copy Markdown

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@angehu-nv
angehu-nv requested a review from a team July 20, 2026 23:58
@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Jul 20, 2026
@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR makes PhysX articulation index resolvers accept default PyTorch integer tensors. The main changes are:

  • Cast torch.int64 joint, body, and tendon IDs to torch.int32.
  • Wrap PyTorch index tensors as Warp arrays before kernel use.
  • Document the PhysX compatibility fix in the changelog.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The four resolvers apply the same conversion pattern.
  • The explicit Warp-array branches preserve the previous pass-through behavior.

Important Files Changed

Filename Overview
source/isaaclab_physx/isaaclab_physx/assets/articulation/articulation.py Converts PyTorch index tensors into Warp-compatible int32 arrays across four articulation ID resolvers.
source/isaaclab_physx/changelog.d/angehu-torch-int64-to-32.rst Documents the corrected handling of default-dtype PyTorch index tensors.

Reviews (1): Last reviewed commit: "Cast torch tensors in ID resolvers to in..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant