-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Speed up environment smoke tests and cover EventManager interval handlers #5713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ooctipus
merged 4 commits into
isaac-sim:develop
from
nvsekkin:esekkin/force-interval-events
May 21, 2026
+63
−3
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
source/isaaclab_tasks/changelog.d/esekkin-force-interval-events.skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Test-only change. | ||
|
|
||
| * Reduced the default ``num_steps`` from 100 to 20 in ``_run_environments``. | ||
| * Tuned ``test_environments`` to pass ``force_interval_events=True`` so ``EventManager`` interval handlers | ||
| (e.g. locomotion ``push_robot``) run on step 1 instead of never firing within the legacy step budget. |
6 changes: 6 additions & 0 deletions
6
source/isaaclab_tasks/changelog.d/esekkin-pr-a-newton-xfail.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Removed the stale file-level ``@pytest.mark.xfail`` decorator on | ||
| ``test_environments_newton`` (the cited Hydra deep-nesting issue was already | ||
| resolved by PR #5029 and follow-ups #5130 / #5177). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dir()iteration may skip frozen-dataclass configs silentlydir(events_cfg)returns all public names — including callable methods and descriptors. Thetry/except AttributeErrorguards against runtime property errors, but the subsequent assignmentterm.interval_range_s = (1e-6, 1e-6)(line 250) is unguarded. If anyEventTermCfgsubclass is declared withfrozen=True(or uses__setattr__guards), the assignment raisesFrozenInstanceError(a subclass ofTypeError) and propagates uncaught, aborting the test with a confusing traceback rather than a helpful assertion failure. Wrapping the assignment in atry/except (AttributeError, TypeError)block would make the helper resilient to these cases.