Skip to content

Fixes camera fast path logic and GPU buffer in dexsuite#4776

Merged
kellyguo11 merged 27 commits intoisaac-sim:developfrom
kellyguo11:fix-buffer-camera
Mar 2, 2026
Merged

Fixes camera fast path logic and GPU buffer in dexsuite#4776
kellyguo11 merged 27 commits intoisaac-sim:developfrom
kellyguo11:fix-buffer-camera

Conversation

@kellyguo11
Copy link
Contributor

@kellyguo11 kellyguo11 commented Feb 28, 2026

Description

Fixes a bad merge of the camera class logic to check for when to enable the fast paths.

Also fixes GPU buffer size that now needs to be increased for dexsuite environments.

Fixes IMU tests and URDF converter logic.

Fixes teleop tests where patching wasn't working correctly with the new lazy export mechanism.

Switches Factory and Forge environments to use timestamp logging to avoid overwriting the same folder when running multiple training runs.

Removes omni.kit.pip_archive from our app files to avoid any version conflicts between our and Kit's python dependencies.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Feb 28, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Fixed camera fast path logic by replacing restrictive allowlist check with simpler RGB/RGBA detection. The new approach correctly enables the fast rendering path whenever full color rendering is not needed, supporting more data type combinations like depth + normals or depth + segmentation.

  • Replaced allowlist-based logic (checking if all types in {depth, albedo, distance_to_*}) with direct RGB/RGBA check
  • Added GPU buffer capacity overrides for dexsuite environments (gpu_found_lost_aggregate_pairs_capacity=2**29, gpu_total_aggregate_pairs_capacity=2**25)

Confidence Score: 5/5

  • This PR is safe to merge with no concerns
  • Both changes are straightforward bug fixes. The camera logic simplification makes the code cleaner and more correct, enabling fast path for more valid scenarios. The GPU buffer increases address capacity issues in dexsuite environments, following patterns used in other complex manipulation tasks.
  • No files require special attention

Important Files Changed

Filename Overview
source/isaaclab/isaaclab/sensors/camera/camera.py Simplified fast path logic to check for RGB/RGBA rendering needs instead of allowlist approach
source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/dexsuite/dexsuite_env_cfg.py Increased GPU aggregate pair buffer capacities to handle complex collision interactions

Last reviewed commit: 04aa559

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@kellyguo11 kellyguo11 requested a review from hhansen-bdai as a code owner March 1, 2026 19:19
@github-actions github-actions bot added the isaac-sim Related to Isaac Sim team label Mar 1, 2026
@kellyguo11 kellyguo11 requested a review from jtigue-bdai as a code owner March 2, 2026 00:37
@github-actions github-actions bot added the isaac-mimic Related to Isaac Mimic team label Mar 2, 2026
@kellyguo11 kellyguo11 merged commit 674fbd0 into isaac-sim:develop Mar 2, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working infrastructure isaac-lab Related to Isaac Lab team isaac-mimic Related to Isaac Mimic team isaac-sim Related to Isaac Sim team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants