Fixes camera fast path logic and GPU buffer in dexsuite#4776
Merged
kellyguo11 merged 27 commits intoisaac-sim:developfrom Mar 2, 2026
Merged
Fixes camera fast path logic and GPU buffer in dexsuite#4776kellyguo11 merged 27 commits intoisaac-sim:developfrom
kellyguo11 merged 27 commits intoisaac-sim:developfrom
Conversation
Contributor
Greptile SummaryFixed camera fast path logic by replacing restrictive allowlist check with simpler RGB/RGBA detection. The new approach correctly enables the fast rendering path whenever full color rendering is not needed, supporting more data type combinations like depth + normals or depth + segmentation.
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 04aa559 |
…blic into fix-buffer-camera
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bad merge of the camera class logic to check for when to enable the fast paths.
Also fixes GPU buffer size that now needs to be increased for dexsuite environments.
Fixes IMU tests and URDF converter logic.
Fixes teleop tests where patching wasn't working correctly with the new lazy export mechanism.
Switches Factory and Forge environments to use timestamp logging to avoid overwriting the same folder when running multiple training runs.
Removes omni.kit.pip_archive from our app files to avoid any version conflicts between our and Kit's python dependencies.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there