Skip to content

fix(range): update tick styling and border radius #31080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OS-giulianasilva wants to merge 7 commits into
base: next
Choose a base branch
from
Open

fix(range): update tick styling and border radius #31080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
86e3459
fix(range): update tick styling and border radius to match Figma
OS-giulianasilva Apr 14, 2026
5ae827e
chore(): update build files
OS-giulianasilva Apr 14, 2026
05d635e
style(range): clean up whitespace in SCSS file
OS-giulianasilva Apr 14, 2026
4763043
chore(): add updated snapshots
Ionitron Apr 14, 2026
8ac3957
fix(range): update tick styling and improve range bar structure
OS-giulianasilva Apr 15, 2026
58b4383
style(range): adjust formatting in range bar component
OS-giulianasilva Apr 15, 2026
c5fc6f7
Merge branch 'next' into ROU-12467-ticks-styling
OS-giulianasilva Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions core/src/components/range/range.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,30 +75,35 @@
@include margin(null, null, calc(globals.$ion-space-200 + globals.$ion-font-size-300), null);
}

.range-bar.range-bar-active {
bottom: 0;
.range-bar {
&.has-ticks {
Copy link
Copy Markdown
Contributor

@thetaPC thetaPC Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this to be .range-bar.has-ticks. Nested styles like these can get hard to read.

@include border-radius(0);
}

width: auto;
&.range-bar-active {
Copy link
Copy Markdown
Contributor

@thetaPC thetaPC Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this to be .range-bar.range-bar-active. Nested styles like these can get hard to read.

bottom: 0;

background: var(--bar-background-active);
width: auto;

&.has-ticks {
@include border-radius(0);
@include margin(null, calc(-1 * globals.$ion-scale-100 * 0.5), null, calc(-1 * globals.$ion-scale-100 * 0.5));
background: var(--bar-background-active);

&.has-ticks {
Copy link
Copy Markdown
Contributor

@thetaPC thetaPC Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this to be .range-bar-active.has-ticks. Nested styles like these can get hard to read.

@include margin(null, calc(-1 * globals.$ion-scale-100 * 0.5), null, calc(-1 * globals.$ion-scale-100 * 0.5));
}
}
}

.range-tick {
@include margin-horizontal(calc(globals.$ion-scale-100 * -0.5), null);
@include border-radius(globals.$ion-border-radius-0);
@include border-radius(globals.$ion-border-radius-400);

position: absolute;
top: calc((var(--height) * 0.5) - (globals.$ion-scale-300 * 0.5));
top: calc((var(--height) * 0.5) - (globals.$ion-scale-400 * 0.5));

width: globals.$ion-scale-100;
height: globals.$ion-scale-300;
width: globals.$ion-scale-050;
height: globals.$ion-scale-400;

background: globals.$ion-primitives-neutral-100;
background: var(--bar-background);
pointer-events: none;
}

Expand Down
9 changes: 8 additions & 1 deletion core/src/components/range/range.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,14 @@ export class Range implements ComponentInterface {
))}

<div class="range-bar-container">
<div class="range-bar" role="presentation" part="bar" />
<div
Copy link
Copy Markdown
Contributor

@thetaPC thetaPC Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these changes being applied? These are already in next. You might need to sync with next to get them.

Copy link
Copy Markdown
Contributor Author

@OS-giulianasilva OS-giulianasilva Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permalink you attached refers to the bar-active part of the range bar. What I changed was the bar part that was missing this logic.

class={{
'range-bar': true,
'has-ticks': ticks.length > 0,
}}
role="presentation"
part="bar"
/>
<div
class={{
'range-bar': true,
Expand Down
Binary file modified ...c/range.e2e.ts-snapshots/range-ticks-ionic-md-ltr-light-Mobile-Chrome-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../range.e2e.ts-snapshots/range-ticks-ionic-md-ltr-light-Mobile-Firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...c/range.e2e.ts-snapshots/range-ticks-ionic-md-ltr-light-Mobile-Safari-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading