fix(range): update tick styling and border radius to match Figma#31080
Open
OS-giulianasilva wants to merge 4 commits intonextfrom
Open
fix(range): update tick styling and border radius to match Figma#31080OS-giulianasilva wants to merge 4 commits intonextfrom
OS-giulianasilva wants to merge 4 commits intonextfrom
Conversation
- set the `--bar-border-radius` to 0 when `ion-range` has `.ticks`. previously, the bar border radius 0 was only set to the active bar. - updated the tick's width and height - updated the tick brackground to match the bar background
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OS-giulianasilva
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
ticks="true",the active bar segment is forced to a 0 border radius, while the inactive segment remains rounded.What is the new behavior?
.has-ticksand instead rely on the host class variable--bar-border-radius..range-tickfrom a hardcoded neutral value to a CSS variable--bar-background, ensuring the ticks and bar share the same color.Does this introduce a breaking change?
Other information
Before:
After: