Integration tests against an IRIS container for release-preparation PRs - #1870
Draft
isc-klu wants to merge 19 commits into
Draft
Integration tests against an IRIS container for release-preparation PRs#1870isc-klu wants to merge 19 commits into
isc-klu wants to merge 19 commits into
Conversation
isc-klu
force-pushed
the
integration-tests
branch
2 times, most recently
from
September 10, 2026 21:46
1219d08 to
1d42286
Compare
isc-klu
force-pushed
the
integration-tests
branch
2 times, most recently
from
September 10, 2026 22:41
96f2c2a to
e17b7bc
Compare
Replaces the placeholder test with a suite that opens a multi-root workspace whose folders connect to one iris-community container by each supported mechanism (objectscript.conn host/port, docker-compose port resolution, intersystems.servers entry, isfs), plus an inactive folder pointing at an unreachable host. The container's /api/atelier session timeout is 10 s so expired-session recovery is exercised. Runs from a new prepare-release.yml workflow on PRs from prepare-* branches and on manual dispatch; the old npm test step is removed from the per-PR workflows. Also fixes the runner, which could not launch VS Code at all: bump @vscode/test-electron to 3.x (2.x looks for the renamed Contents/MacOS/Electron), drop the rejected -n arg, unset ELECTRON_RUN_AS_NODE inherited from extension-spawned terminals, use a fresh user-data-dir per run, and make the mocha runner's promise settle when the tests finish. Closes intersystems-community#1863 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
isc-klu
force-pushed
the
integration-tests
branch
from
September 10, 2026 22:59
e17b7bc to
d0543c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1863. Integration suite against a real
iris-community:latest-cdcontainer, run from a newprepare-release.ymlworkflow onprepare-*PRs and on manual dispatch. Thenpm teststep leaves the per-PR workflows.Configurations × checks
src/test/suite/extension.test.ts. Each workspace folder intest-fixtures/ci.code-workspaceis one configuration, with its settings in the matching directory undertest-fixtures/. The same check runs against every configuration it applies to.activeclient-hostport: client-side,objectscript.connwith host/port and credentials, nointersystems.serversclient-compose: client-side,objectscript.connwith docker-compose and credentials, nointersystems.serversclient-named-server: client-side,objectscript.conn.servernaming anintersystems.serversentry with credentialsclient-inactive: client-side,objectscript.connactive: falsenaming anintersystems.serversentry without a password (unreachable host)server-side:intersystems.serversentry with credentialsChecks: connects = credentials in settings used without prompting,
serverForUrireturns them; save + delete syncs = a class written through the folder appears on the server and disappears when deleted, verified over REST; toggleactive=objectscript.conn.activefalse then true is honoured; expired session = after 13 s idle (server timeout 10 s) save + delete still works without prompting; check after expiry = the connection check on re-enabling after 13 s idle recovers without prompting.Related issues and PRs: connects → language-server#415/#1846 (
client-hostport), #1858/#1860 (client-compose), #1837/#1836, #1820 (client-named-server,server-side);client-inactive→ #1832/#1835, #1740, #1825/#1824; toggle → #1747/#1748, #1805/#1808; expired session → #1829, #1823/#1830, #1824; check after expiry → #1861/#1864.Verified to catch regressions by reverting the fix on master and watching the suite fail: #1846, #1860, #1830. Reverting #1835 did not fail the suite (activation didn't block here).
Skipped, pre-existing bugs: check after expiry prompts for a password and never settles (#1861); fails on master, passes on the #1864 branch, which should un-skip it.
client-composenever goes inactive:AtelierAPI.setConnectionhard-codesactive: truefor a resolved docker-compose connection.Not covered: unauthenticated connections (#1840; IRIS routes any
.../api/atelierpath to the primary web app), UI-only paths (#1787, #1784), activation timeout (#1810), session leaks (#1805).How it works
Every configuration connects to the same container. Its
/api/ateliersession timeout is 10 s so expiry checks hit a real 401. ~90 s once the container is up;test-fixtures/README.mdcovers running it locally with Podman or Docker.Activation dedupes connection checks by server name, so
client-named-server(serverci, shared withserver-side) only connects once a document in it becomes active; the test opens a file there to mirror that.Runner fixes
npm testcould not launch VS Code:@vscode/test-electron2.x looks for the since-renamedContents/MacOS/Electron(bumped to 3.x); Electron rejects-n;ELECTRON_RUN_AS_NODEfrom an extension-spawned terminal made VS Code run as plain Node; the mocha promise settled before the tests ran.