Skip to content

CI check for the pre-release test workflow (fork only) - #1

Closed
isc-klu wants to merge 2 commits into
masterfrom
prepare-ci-check
Closed

CI check for the pre-release test workflow (fork only)#1
isc-klu wants to merge 2 commits into
masterfrom
prepare-ci-check

Conversation

@isc-klu

@isc-klu isc-klu commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Throwaway PR on the fork so the prepare-* workflow from intersystems-community#1870 runs in GitHub CI.

isc-klu and others added 2 commits September 10, 2026 16:30
- Bump @vscode/test-electron to 3.x: 2.x looks for Contents/MacOS/Electron, which VS Code 1.110+ renamed, so every run failed with ENOENT on macOS. Its typings need skipLibCheck with our pinned @types/node.
- Drop the `-n` launch arg, which Electron rejects when the runner spawns it directly.
- Unset ELECTRON_RUN_AS_NODE, inherited from extension-spawned terminals, which made the downloaded VS Code run as plain Node and try to execute the workspace file.
- Use a fresh user-data-dir per run so cached state can't leak between runs.
- Make the mocha runner's promise settle when the tests finish instead of immediately, so failures actually fail the run.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Replaces the placeholder test with a suite that opens a multi-root workspace whose folders connect to
one iris-community container by each supported mechanism (objectscript.conn host/port, docker-compose
port resolution, intersystems.servers entry, isfs), plus an inactive folder pointing at an unreachable
host. The container's /api/atelier session timeout is 10 s so expired-session recovery is exercised.

Runs from a new prepare-release.yml workflow on PRs from prepare-* branches and on manual dispatch;
the old npm test step is removed from the per-PR workflows.

Closes intersystems-community#1863

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@isc-klu

isc-klu commented Sep 10, 2026

Copy link
Copy Markdown
Owner Author

Workflow verified green on the fork (run 34529443459); closing.

@isc-klu isc-klu closed this Sep 10, 2026
@isc-klu
isc-klu deleted the prepare-ci-check branch September 10, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant