Skip to content

Skip checking isExecutable for matched WP-CLI on Windows #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meszarosrob merged 3 commits into from
Aug 6, 2026
Merged

Skip checking isExecutable for matched WP-CLI on Windows #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3887e15
Don't check on windows if the wp-cli is executable
meszarosrob Aug 5, 2026
68a59e2
Skip the test on windows
meszarosrob Aug 5, 2026
6ec82cd
Make the non executable permission explicit
meszarosrob Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Path/Finder/WpCliPathFinder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,15 @@ public function find(): string
throw new Exception();
}

if (!$firstMatch->isExecutable()) {
if (!$this->isWindows() && !$firstMatch->isExecutable()) {
throw new Exception('The matched WP-CLI binary is not executable.');
}

return $firstMatch->getPathname();
}

private function isWindows(): bool
{
return \DIRECTORY_SEPARATOR === '\\';
}
}
5 changes: 5 additions & 0 deletions tests/phpunit/Functional/Path/Finder/WpCliPathFinderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,14 @@ public function testWpContentDirectoryIsIgnoredWhenWpCliIsLocated(): void

public function testThrowsWhenLocatedWpCliIsNotExecutable(): void
{
if (\DIRECTORY_SEPARATOR === '\\') {
$this->markTestSkipped('Windows has no POSIX file permissions to test.');
}

$this->expectExceptionMessageMatches('/The matched WP-CLI binary is not executable/');

$this->filesystem->appendToFile($this->workspace . '/acme/vendor/bin/wp', '');
$this->filesystem->chmod($this->workspace . '/acme/vendor/bin/wp', 0644);

(new WpCliPathFinder(
$this->localDependencyPath($this->workspace . '/acme'),
Expand Down
Loading