Skip checking isExecutable for matched WP-CLI on Windows - #13
Merged
Conversation
Chrico
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #12.
Compared to the suggestion in the issue, this retains the current functionality (checking the file's executable permission) on non-Windows systems.
I think an earlier error message, as we have now, doesn't hurt in case some false positive wp matches occur, at least until we make the location of WP and WP-CLI configurable via an environment variable, as possibly suggested in the #7.
If more issues appear with Windows and we want to introduce more conditions, we can extract the
isWindowsinto a class and inject it, but for now, I think this does it.