Skip to content

Conversation

@sensei-hacker
Copy link
Member

@sensei-hacker sensei-hacker commented Dec 23, 2025

User description

Summary

Disable dynamic notch filter by default for the BLUEBERRYF435WING target to improve performance.

Changes

  • Added gyroConfigMutable()->dynamicGyroNotchEnabled = 0; to target config
  • Wrapped in #ifdef USE_DYNAMIC_FILTERS for proper conditional compilation
  • Added sensors/gyro.h include

Rationale

  • This wing target is performance-constrained
  • Wing aircraft typically don't benefit from dynamic notch filtering (designed for multirotor motor noise)
  • Disabling reduces CPU overhead and improves task scheduling margin

Testing

  • Built BLUEBERRYF435WING and BLUEBERRYF435WING_SD targets successfully
  • Both variants compile without errors

PR Type

Enhancement


Description

  • Disables dynamic notch filter by default for BLUEBERRYF435WING target

  • Reduces CPU overhead on performance-constrained wing aircraft

  • Adds conditional compilation guard for dynamic filter feature

  • Includes explanatory comments for maintenance clarity


Diagram Walkthrough

flowchart LR
  A["BLUEBERRYF435WING config"] -- "add gyro.h include" --> B["Include headers"]
  A -- "disable dynamic notch filter" --> C["Performance optimization"]
  A -- "wrap with USE_DYNAMIC_FILTERS" --> D["Conditional compilation"]
Loading

File Walkthrough

Relevant files
Enhancement
config.c
Disable dynamic notch filter with conditional compilation

src/main/target/BLUEBERRYF435WING/config.c

  • Added #include "sensors/gyro.h" header for gyro configuration access
  • Disabled dynamic gyro notch filter by default via
    gyroConfigMutable()->dynamicGyroNotchEnabled = 0;
  • Wrapped filter disable in #ifdef USE_DYNAMIC_FILTERS conditional
    compilation guard
  • Added detailed comments explaining the performance optimization
    rationale for wing aircraft
+8/-0     

This wing target is performance-constrained and wing aircraft typically
don't benefit from dynamic notch filtering, which is primarily designed
for detecting and filtering multirotor motor noise.

Disabling the dynamic notch filter by default reduces CPU overhead
and improves task scheduling margin on this board.
@qodo-code-review
Copy link
Contributor

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

@sensei-hacker sensei-hacker added this to the 9.0 milestone Dec 23, 2025
@sensei-hacker sensei-hacker merged commit b5da577 into iNavFlight:maintenance-9.x Dec 24, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant