Skip to content

registry: close validate() over the ADR 0004 fields; THY-1 lineage labels - #102

Open
hyperpolymath wants to merge 1 commit into
mainfrom
claude/registry-closed-validate
Open

hyperpolymath wants to merge 1 commit into
mainfrom
claude/registry-closed-validate

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Two small fixes found during the trope-checker proof close-out.

  1. validate() in scripts/registry/claims-registry.mjs accepted any extra field. A row carrying pwg: 'PWG-1', token or nonsense: 42 passed. ADR 0004 lists the exact fields, and says a record holds no grade, token, leg or flag. The validator is now closed over that set, as bridges.mjs and theory.mjs already are.
  2. docs/status/PROOF-STATUS.adoc still labelled the THY-1 Rocq and Lean CI receipts of run 42896264290 "(current)". The receipt deed records them as superseded by run 43498592499.

Changes

  • validate() refuses any top-level field outside id, repo, claim, kind, statement, status_doc, agda, shelf, source_commit, receipt. It also refuses any field of agda other than {module, names}, and any field of receipt other than {path, sha256}. A record that is not an object is refused too.
  • New test validation is closed over the ADR 0004 field set. It covers pwg, grade, token, legs, leg, flags, foundation_diverse, nonsense, a grade nested in agda, a grade nested in receipt, and a missing required field.
  • PROOF-STATUS, THY-1 Rocq and Lean rows: run 42896264290 is now labelled "(superseded on 2026-11-13)". Each row adds the current receipt, run 43498592499 at main 034f215. This follows the Agda row, which already said so. Evidence: verification/receipts/theory_praxis.deed lines 66–81 and 89–105, written in 580f9f9 on 2026-11-13. The file SHA-256s in the current manifests (e2f900…, 4158e5…) match the ones the doc gives, so "unchanged" is checked, not assumed. This is PROOF-POLICY §8.4 rule 5.

Shared-file note: none of the open PRs (#96, #98, #99, #101) touch these three files. I ran the closed validator on the claims.jsonl of #96 (49 rows) and of #99 (22 rows). Both pass, so this change does not break either of them.

Testing

Falsified first. I ran the new test against the pre-fix validator and it failed (Received function did not throw). I also ran a probe script against the pre-fix validator with ten rows: pwg, grade, token, legs, leg, flags, foundation_diverse, nonsense:42, agda.pwg and receipt.pwg. Every row came back ACCEPTED. After the fix all ten are refused, each with a message that names the field.

MATHESIS_STANDARDS=<standards @ e5a39d7> bun test tests/registry/ → 27 pass, 0 fail. The reader digest 37ff85be… was verified.

Not done here: just check. It needs the pinned Guix shell. CI runs registry-check.

Not changed (reported to the owner separately)

  • The THY-1 Lean leg's empty (axioms) is vacuous. lean4/FeatureReachability.lean declares no theorem or lemma, and the axiom audit keeps only .thmInfo. This PR keeps the historical sentence "no declared theorem depends on an axiom" on the superseded line. For the current receipt, the new text says only that it "records … an empty (axioms) clause", and does not claim more.
  • ADR 0004 says agda is null for a non-theorem. validate() still does not enforce that. Left alone, because it is outside the scope of this PR.

RSR Quality Checklist

  • Tests pass (bun test tests/registry/)
  • No banned language patterns (Bun JS only)
  • SPDX headers unchanged on modified files
  • No secrets

Generated by Claude Code

…bels

validate() in scripts/registry/claims-registry.mjs accepted any extra field,
so a row could carry pwg, token or nonsense:42 and pass. ADR 0004 lists the
exact fields and says a record holds no grade, token, leg or flag. The
validator is now closed over that set, and over the fields of agda
{module, names} and receipt {path, sha256}, as bridges.mjs and theory.mjs
already are. The new test was run against the old validator first: it
failed, and each of the ten probe rows was accepted.

PROOF-STATUS.adoc labelled the Rocq and Lean CI receipts of run 42896264290
"(current)". The receipt deed (580f9f9, 2026-11-13) records them as
superseded by run 43498592499 at 034f215. The Agda row already said so; the
Rocq and Lean rows now match it (PROOF-POLICY 8.4 rule 5).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDg2kzHbnbH2pmDf2Ar
@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 16, 2026 23:32
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-16T23:32:16.787097Z
We couldn’t complete this review. Comment @codex review to try again.
3ea5cf1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 327e4d2 and 3ea5cf1.

Files selected for processing: 3

  • docs/status/PROOF-STATUS.adoc
  • scripts/registry/claims-registry.mjs
  • tests/registry/claims-registry.test.mjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 16, 2026 23:32
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

hyperpolymath added a commit that referenced this pull request Nov 17, 2026
…rkers (#105)

## Summary

This refreshes the census rows for hyperpolymath/hypatia,
metadatastician/standards and the 14 rows that have Idris2 proofs and a
non-zero `unsafe` count. The hypatia row now covers the actions.lock
closure work in hyperpolymath/hypatia#1026 and
hyperpolymath/hypatia#1187.

This PR first carried its own fix for a scanner false positive: the
Idris2 function `partial'` was counted as four `partial` annotations.
#101 landed on main meanwhile with the same fix, applied to every marker
rule. The merge `39ea12a` keeps main's scanner and drops this PR's
narrower rule and test. **The PR now changes census data only.**

## Changes

| Repository | Change |
|---|---|
| hyperpolymath/hypatia @ `29a9e4a` | own files 58 → 77, declarations
680 → 1040, unsafe 0 |
| metadatastician/standards @ `b49a33e` | own files 2 → 3, declarations
40 → 66 |
| hyperpolymath/echidna | own files 170 → 163, declarations 1969 → 1676,
from its newer commits |
| 13 other Idris2 rows with unsafe markers | move to their current
commits; counts unchanged |

The 13 rows in the last line are ambientops, deed-core,
developer-ecosystem, ephapax, poly-ssg, proven, raze-tui, reposystem,
ssg-collection, cerro-torre, gossamer, paint-type and vordr.

No unsafe count changed in the 14 refreshed Idris2 rows. Their markers
are real `partial` annotations, and the false positive affected only
hypatia.

`docs/atlas/generated/*` is regenerated with `census-atlas.mjs build`
and `render-catalogue.sh`.

## Follow-up

Standards' row still names `docs/proof-debt.adoc` as its status
document. standards#1635 renames standards' record to
`3-practice/PROOF-STATUS.adoc` and retires that ledger. Once it merges,
one more `update-rows.sh metadatastician/standards` will name the new
file.

## RSR Quality Checklist

### Required

- [x] Tests pass: `tests/census/*.sh` all pass, `bun test
tests/atlas/census-atlas.test.mjs` 13/13
- [x] Catalogue matches rows; `census-atlas.mjs check` PASS
- [x] No banned language patterns, no secrets
- [x] No source files changed

### As Applicable

- [ ] Deed and ROADMAP: not changed; project state did not change

## Open PRs this touches

This PR changes only `docs/atlas/census/rows.jsonl` and the four
generated atlas files. Of the other open PRs:

- **#98** refreshes the same hypatia row at
`6f3f16f`. This PR refreshes it at `29a9e4a`, which is later and
includes hypatia#1187. If this merges, #98 is superseded.
- **#96** (resource-algebra row) and
**#100** (ddraig-ssg row) refresh different rows.
They still edit the same files, so whichever merges second will
conflict. To resolve, rerun `scripts/census/update-rows.sh` for its row
on top of the new main, then regenerate. Do not hand-merge the generated
files.
- **#99** touches
`docs/atlas/generated/registry.adoc`, which this PR does not change.
**#102** and **#103** do not
overlap with this PR.

## Testing

Ran `update-rows.sh` on the 16 repositories on top of main at `261e6dc`.
Then ran the census tests, the catalogue diff, and the atlas build,
check and tests.

No licence content is touched.

https://claude.ai/code/session_01TbbnKqskQA5mj5gfMniPzi


---
_Generated by [Claude Code](https://claude.ai/code)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants