Repository navigation
fix(ci): Dependabot leaves attested reusable workflows alone; add the re-attest tool - #696
Open
hyperpolymath wants to merge 2 commits into
Open
hyperpolymath wants to merge 2 commits into
hyperpolymath wants to merge 2 commits into
Conversation
#686 (Dependabot actions bump) moved hypatia-scan.yml's reusable call to hyperpolymath/hypatia/.github/workflows/credential-read-check.yml from b93f0615 to 29a9e4a8 without updating the pinned-source manifest or the closure receipts, so 'Pinned source closure' (and E2E, which requires it) has failed on main since 6a6b748 with SOURCE-ACTIVE-MISSING, and on every PR merged with main. Fetched both commits from hyperpolymath/hypatia: the workflow is byte- identical at both (blob 15c597ea, sha256 645e8ac8...), and its only uses are step-security/harden-runner@1d88384f. So only the commit moves: - pinned-reusable-sources.json: the record's commit -> 29a9e4a8 (blob, content_sha256 and uses unchanged, verified against the fetched file). - lock-closure-receipts.tsv: the receipt block re-emitted with audit-lock-closure.sh --emit-receipt from the fetched source. audit-pinned-reusable-sources.sh: findings 1 -> 0. audit-lock-closure.sh: fatal 1 -> 0 (review/accepted/not-run counts unchanged). pinned-reusable-sources-test: 55/55. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDhFeexmokLqLRfZNce
… re-attest tool #686 showed the gap: Dependabot bumped an attested reusable-workflow pin (hypatia credential-read-check) without re-attesting it, and its own 'Pinned source closure' and 'E2E tests' failures did not stop the merge, so main went red. Dependabot cannot re-attest, so these pins must not be its to move. - .github/dependabot.yml: a name-only ignore for each ACTIVE source in scripts/lib/pinned-reusable-sources.json, using Dependabot's own name for a reusable workflow (owner/repo/.github/workflows/file.yml, as in #686's body). Name-only, like the CodeQL hold: a SHA re-bump slips past a version-scoped ignore. Ordinary actions keep updating. - scripts/reattest-pinned-source.sh: the deliberate path. It moves one pin in the manifest and re-emits its receipt (audit-lock-closure.sh --emit-receipt) only when no judgement is needed: the file is byte- identical at the new commit, every caller already calls it, no other record shares the old commit, and the receipt block has the usual layout. Anything else is refused with the reason, exit 3, nothing changed. It ends by running the pinned-source audit. Replayed on main@dec1e7c it reproduces #694 byte for byte. - scripts/tests/dependabot-attested-ignore-test.sh: the ignore list equals the manifest's active sources (missing, stale and version-scoped entries each fail; negative controls). Ruby YAML, already on the runner. - scripts/tests/reattest-pinned-source-test.sh: fixture move, idempotent rerun, five refusals, bad arguments, and the #686 replay when github.com and the commit are available (NOT RUN otherwise, never passed). 29/29. - e2e.yml: both suites run in the 'Pinned source closure' job. No new action, so actions.lock is unchanged (check-lock-sync clean). Making 'Pinned source closure' and 'E2E tests' required on main is a branch-protection setting for the owner; this change cannot make it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDhFeexmokLqLRfZNce
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
hyperpolymath
marked this pull request as ready for review
November 17, 2026 22:07
hyperpolymath
changed the base branch from
claude/reattest-hypatia-credential-read-check
to
main
November 18, 2026 00:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Stacked on #694. The base is #694's branch, because
main's pinned-source audit stays red until #694 merges. Retarget tomainafter it merges.The gap
#686 (Dependabot) bumped an attested reusable-workflow pin,
hyperpolymath/hypatia/.github/workflows/credential-read-check.yml, without re-attesting it. Its own Pinned source closure and E2E tests failed, but that didn't block the merge, somainwent red. Dependabot can't re-attest a pin, so these pins shouldn't be its to move.Change
.github/dependabot.yml: one name-onlyignoreentry for each active source inscripts/lib/pinned-reusable-sources.json. The names use Dependabot's own form for a reusable workflow,owner/repo/.github/workflows/file.yml, as in chore(deps): bump the actions group across 1 directory with 2 updates #686's body. The entries are name-only, like the existing CodeQL hold, because a SHA re-bump slips past a version-scoped ignore. Ordinary actions keep auto-updating.scripts/reattest-pinned-source.sh: the deliberate way to move an attested pin.audit-lock-closure.sh --emit-receipt) only when no judgement is needed:uses:lines for review.Pinned source closurejob:dependabot-attested-ignore-test.shchecks that the ignore list equals the manifest's active sources. Negative controls cover missing, stale and version-scoped entries. It parses YAML with Ruby, which the runner already has, so no new action is needed andactions.lockis unchanged.reattest-pinned-source-test.sh(29/29) covers the move on a fixture, an idempotent rerun, five refusals, bad arguments, and a replay of chore(deps): bump the actions group across 1 directory with 2 updates #686 onmain@dec1e7c. The replay is reported NOT RUN, never passed, when github.com or that commit isn't available.Evidence
main@dec1e7c, the tool's output is byte-identical to fix(ci): re-attest hypatia credential-read-check at 29a9e4a8 (Pinned source closure red since #686) #694's manifest and receipts, and the pinned-source audit reportsfindings=0.check-lock-sync.shis clean after the workflow edit.Not in this PR (owner action)
Make Pinned source closure and E2E tests required status checks on
main. That's a branch-protection setting, so code can't change it. It's the half of the fix that would have stopped #686 from merging.Generated by Claude Code