Skip to content

fix(ci): re-attest hypatia credential-read-check at 29a9e4a8 (Pinned source closure red since #686) - #694

Closed
hyperpolymath wants to merge 1 commit into
mainfrom
claude/reattest-hypatia-credential-read-check
Closed

hyperpolymath wants to merge 1 commit into
mainfrom
claude/reattest-hypatia-credential-read-check

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Problem

Since 6a6b748 (#686, the Dependabot actions bump), the Pinned source closure check has failed on main with SOURCE-ACTIVE-MISSING. E2E tests fails with it, because E2E requires that check to pass. Every PR that merges main inherits both failures; #691 is one.

#686 moved the reusable call in hypatia-scan.yml from hyperpolymath/hypatia/.github/workflows/credential-read-check.yml@b93f0615 to @29a9e4a8. It didn't update scripts/lib/pinned-reusable-sources.json or scripts/lib/lock-closure-receipts.tsv, so the attested callers no longer match the real ones.

Bisected locally with scripts/audit-pinned-reusable-sources.sh: it passes at cd1e45e and first fails at 6a6b748.

Change

I fetched both commits from hyperpolymath/hypatia. credential-read-check.yml is byte-identical at both: blob 15c597ea, sha256 645e8ac8…. Its only external dependency is step-security/harden-runner@1d88384f. So only the pin moves; what runs does not change.

  • pinned-reusable-sources.json: the record's commit changes to 29a9e4a8. Its blob, content_sha256 and uses are unchanged and match the fetched file.
  • lock-closure-receipts.tsv: the receipt block is re-emitted with audit-lock-closure.sh --emit-receipt hyperpolymath/hypatia@29a9e4a8 --source <fetched file>, not edited by hand.

Verification

Check main (dec1e7c) this branch
audit-pinned-reusable-sources.sh findings=1 (FATAL) findings=0
audit-lock-closure.sh fatal=1 fatal=0 (review/accepted/not-run unchanged)
pinned-reusable-sources-test.sh n/a 55/55

lock-closure-test.sh needs CI's prepared PINNED_SOURCE_CACHE, so CI runs it.

Follow-up (not in this PR)

Dependabot can bump a reusable-workflow pin without re-attesting it, and only this check catches that, after the merge. I'm scoping a way to close that gap separately, as the owner asked.


Generated by Claude Code

#686 (Dependabot actions bump) moved hypatia-scan.yml's reusable call to
hyperpolymath/hypatia/.github/workflows/credential-read-check.yml from
b93f0615 to 29a9e4a8 without updating the pinned-source manifest or the
closure receipts, so 'Pinned source closure' (and E2E, which requires it)
has failed on main since 6a6b748 with SOURCE-ACTIVE-MISSING, and on every
PR merged with main.

Fetched both commits from hyperpolymath/hypatia: the workflow is byte-
identical at both (blob 15c597ea, sha256 645e8ac8...), and its only uses
are step-security/harden-runner@1d88384f. So only the commit moves:

- pinned-reusable-sources.json: the record's commit -> 29a9e4a8 (blob,
  content_sha256 and uses unchanged, verified against the fetched file).
- lock-closure-receipts.tsv: the receipt block re-emitted with
  audit-lock-closure.sh --emit-receipt from the fetched source.

audit-pinned-reusable-sources.sh: findings 1 -> 0. audit-lock-closure.sh:
fatal 1 -> 0 (review/accepted/not-run counts unchanged).
pinned-reusable-sources-test: 55/55.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDhFeexmokLqLRfZNce
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between dec1e7c and e38857b.

Files ignored due to path filters: 1

  • scripts/lib/lock-closure-receipts.tsv is excluded by !**/*.tsv
Files selected for processing: 1

  • scripts/lib/pinned-reusable-sources.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Owner Author

Closing as superseded by #698, which merged the same re-attestation onto main. Merging this branch onto current main (464fa73) produces a tree identical to main: no diff in scripts/lib/pinned-reusable-sources.json or scripts/lib/lock-closure-receipts.tsv.

#696 (Dependabot ignores for attested reusable workflows, plus scripts/reattest-pinned-source.sh) is retargeted to main. It merges cleanly there. On the merged tree, dependabot-attested-ignore-test.sh passes 4/4. reattest-pinned-source-test.sh passes 28/28, with 1 not run: the replay test, because this clone lacks commit dec1e7c.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants