Skip to content

proofs: merge on partial sections is not a join for the information order - #380

Open
hyperpolymath wants to merge 2 commits into
mainfrom
claude/gracious-darwin-vkgj6l
Open

hyperpolymath wants to merge 2 commits into
mainfrom
claude/gracious-darwin-vkgj6l

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Follow-up to #370, from CodeRabbit's last review, which arrived after the merge.

The overclaim

The EchoPartialSection header and the bridge-status row called the resolve-parametric merge a "join-semilattice of partial sections". Under _⊑_, every value present in a section must stay unchanged in anything above it. So two sections holding different values at one index have no common upper bound at all. merge-comm, merge-assoc and merge-idem are laws of a resolver-parametric merge, not join laws.

Changes

  • New lemma. EchoPartialSection.NoJoin.no-common-upper-bound proves this with a Bool-indexed counter-model. It is checked by Agda, not just stated in prose: --safe --without-K --cubical-compatible, no postulates. It is pinned in Smoke.agda.
  • Wording. The module header, docs/bridges/cross-repo-bridge-status.adoc and docs/echo-types/MAP.adoc now say "resolver-parametric merge algebra" and cite the lemma.
  • Changelog. New entry in CHANGELOG.adoc.

No new module, so All.agda and the kernel-note classification are unchanged.

Validation

  • Local, all passed. Agda 2.7.0.1, stdlib 8326c74 and absolute-zero f486c29, installed by scripts/setup-agda.sh with checksums verified:
    • All.agda, Smoke.agda and AuditSmoke.agda exit 0;
    • scripts/kernel-guard.sh passes;
    • EchoPartialSection.agda keeps the same 12 warnings, all of the existing UnsupportedIndexedMatch class, none in the new block.
  • After merging main (cecc896). main gained CNO bridges: repin absolute-zero to 8a3162a (pc-driven machine) #376 (absolute-zero repinned to 8a3162a), ci(hypatia): pin the scanner to hypatia main 6d8ab66 #378 and docs: fix references to files that no longer exist #379, which touch Smoke.agda, MAP.adoc and the bridge-status page. The merge applied cleanly. Re-run with the toolchain scripts/setup-agda.sh now pins (absolute-zero 8a3162a): All.agda, Smoke.agda and AuditSmoke.agda exit 0, and scripts/kernel-guard.sh passes.
  • CI on fe5f462. The Agda workflow passes (run 44129193750), as do governance, CodeQL, secret scans and Hypatia. CodeRabbit produced no actionable comments.

Generated by Claude Code

…rder

Late review finding on #370 (merged): the module header and the
bridge-status row called the resolve-parametric merge a join-semilattice
of partial sections. Under `_⊑_` every present value must stay unchanged,
so two sections with different values at one index have no common upper
bound at all; merge-comm/assoc/idem are algebraic laws of a
resolver-parametric merge, not join laws.

- EchoPartialSection.NoJoin.no-common-upper-bound proves it (Bool-indexed
  counter-model, `--safe --without-K --cubical-compatible`, no postulates);
  pinned in Smoke.agda.
- Module header, docs/bridges/cross-repo-bridge-status.adoc and MAP.adoc
  now say "resolver-parametric merge algebra" and cite the lemma.
- CHANGELOG entry.

Checked: EchoPartialSection.agda typechecks with Agda 2.7.0.1, stdlib
8326c74, absolute-zero f486c29 (scripts/setup-agda.sh); the warning count
is unchanged (12, all the existing UnsupportedIndexedMatch class, none in
the new block).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDizuhJtQDcxHxM2wj8
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that the merge is resolver-parametric and is not a join under the information order.
    • Documented that partial sections with different values at one index have no common upper bound.
  • Tests
    • Added a proof confirming that no common upper bound exists for sections that disagree at every modality.

The change adds an Agda proof that two partial sections can lack a common upper bound under _⊑_. It pins the result in the smoke manifest and updates the changelog and documentation to describe the merge as resolver-parametric rather than a join for the information order.

Changes: Partial section merge

Layer / File(s) Summary
Prove and pin the no-upper-bound result
proofs/agda/EchoPartialSection.agda, proofs/agda/Smoke.agda
The NoJoin module defines two Boolean-valued partial sections that disagree at each modality and proves that no section is above both under _⊑_. The smoke manifest imports the result.
Clarify the merge description
CHANGELOG.adoc, docs/bridges/cross-repo-bridge-status.adoc, docs/echo-types/MAP.adoc, proofs/agda/EchoPartialSection.agda
The changelog, documentation and module comments describe the merge as resolver-parametric and state that it is not a join for the information order.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • hyperpolymath/echo-types#370: Introduces EchoPartialSection.agda and the resolver-parametric merge laws that this change describes and extends.
Merge Risk: Minimal · up to fe5f4

This change adds a proof that partial sections can lack a common upper bound and updates the docs to call the merge resolver-parametric. It does not change runtime behavior, and no merge-blocking risk was identified. CI should confirm the full Agda build.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: merge on partial sections is not a join for the information order. The changeset adds the NoJoin.no-common-upper-bound lemma and updates the wording in the module hea…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states the purpose of the change: it corrects the overclaimed 'join-semilattice' wording for the resolver-parametric merge on partial sections. It names the new lemma NoJoin.no-common-…
Full details: Title check

Explanation

The title states the main change: merge on partial sections is not a join for the information order. The changeset adds the NoJoin.no-common-upper-bound lemma and updates the wording in the module header and docs to match, so the title describes the primary change.

Full details: Description check

Explanation

The description states the purpose of the change: it corrects the overclaimed 'join-semilattice' wording for the resolver-parametric merge on partial sections. It names the new lemma NoJoin.no-common-upper-bound, the affected files (module header, bridge-status page, MAP.adoc, changelog, Smoke.agda), and the validation steps. This matches the changeset, so the check passes.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4c9bec95-2ff5-4a11-98fa-158b9f27b91f
Commits

Reviewing files that changed from the base of the PR and between 6bc52b8 and fe5f462.

Files selected for processing: 5

  • CHANGELOG.adoc
  • docs/bridges/cross-repo-bridge-status.adoc
  • docs/echo-types/MAP.adoc
  • proofs/agda/EchoPartialSection.agda
  • proofs/agda/Smoke.agda

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 25

  • GitHub Check: CodeRabbit
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / JS runtimes — pnpm
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / UUID v8 conformance
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / JS runtimes — bun
  • GitHub Check: governance / JS runtimes — environment provisions Bun first
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: fleet / Fleet report-backs
  • GitHub Check: scan / rust-secrets
  • GitHub Check: Rocq recheck leg
  • GitHub Check: Bit-narrowing exhibit
  • GitHub Check: Experimental echo-additive
  • GitHub Check: cold-check
  • GitHub Check: check
  • GitHub Check: Cubical epi/mono profile
Additional context used

Learnings: 1

Common learnings

Learnt from: CR
Repo: hyperpolymath/echo-types PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-10-31T20:51:46.566Z
Learning: Source excerpt:
# Working rules in this repo

- Every headline theorem must be pinned in `Smoke.agda` via `using` clause.
Learnt from: CR
Repo: hyperpolymath/echo-types PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-10-20T14:32:49.454Z
Learning: Source excerpt:
# Working rules in this repo

- No postulates unless explicitly isolated and justified.
Learnt from: CR
Repo: hyperpolymath/echo-types PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-10-31T20:51:46.566Z
Learning: Source excerpt:
# Working rules in this repo

- `--safe --without-K` throughout.

@linear-code
linear-code Bot marked this pull request as ready for review November 17, 2026 16:48

Copy link
Copy Markdown
Owner Author

The full local run has finished and passed. I used Agda 2.7.0.1, stdlib 8326c74 and absolute-zero f486c29, with --safe --without-K --cubical-compatible, on this branch's head:

  • All.agda: rc=0
  • Smoke.agda: rc=0
  • AuditSmoke.agda: rc=0
  • scripts/kernel-guard.sh: PASS (the funext-free certificate holds and the classification is in sync)

Generated by Claude Code

Brings in #376 (absolute-zero repinned to 8a3162a), #378 and #379
(doc reference fixes touching Smoke.agda, MAP.adoc and the bridge-status
page), which this PR also edits. Merged cleanly; re-verified below.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDizuhJtQDcxHxM2wj8

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants