Repository navigation
feat(rules): SQ-TOOL-02, SQ-GEN-04, SQ-OWN-13..15 and refs-missing for SQ-LOCK-02 - #159
Conversation
…ng signature for SQ-LOCK-02 Evidence from the rule reconciliation thread, with run URLs: - SQ-TOOL-02 (40th rule, FIX, config only): Dependabot misconfigured_tooling for Bun. MetaManifold-WebUI run 43225380901 /frontend; fixed by hand in MetaManifold-WebUI#330 (package-ecosystem npm to bun, one directory, other entries unchanged). Refers when the directory has a second lockfile or the repository has no matching ecosystem. Its check (the next Dependabot run) has not run yet for #330 and the row says so. - SQ-LOCK-02 also matches 'refs missing from the lockfile' (this-ssg run 43156768667). The this-ssg slsa-github-generator@f7dd8c54 case is listed in its refer-when: gh actions-lock is not yet shown to regenerate it, so the guard sends it to a referral until a live run proves it. - ADR 0004 mapping table: dependabot_ecosystem_mismatch, actions_lock_missing_ref, repository_map_stale (SQ-GEN-01) and generated_file_stale (referral). fmt, clippy -D warnings and the workspace tests pass (200 in squabble-core). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…p evidence Evidence from the rule reconciliation thread, with run URLs: - SQ-GEN-04 (FIX): 'kyaml-format: <file> is not KYAML' (quintessence run 43156792336). Fix is scripts/kyaml-format.sh <file>, named in the rule and never taken from the log; needs mikefarah Go yq, and a missing yq means the check did not run. - SQ-OWN-13 (OWNER): 'gh: Repository rule violations found ... (HTTP 409)' (Apodeixis.jl run 43257204071). Disjoint from SQ-OWN-04 (the git GH013 form); a test pins that neither claims the other. - SQ-OWN-14 (OWNER): 'non-v8 UUID literal' / 'UUID check failed' (Apodeixis.jl run 43257204302). The squabbler never mints or rewrites a UUID. - SQ-OWN-15 (OWNER): Sonar 'Not authorized or organization not found' (lithoglyph run 43152462261). Never skip the Sonar step. - ADR 0004: rows, mapping table, counts (44 rules, 24 first-line). fmt, clippy -D warnings and the workspace tests pass (201 in squabble-core). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
…0 text Hypatia's secret scan flagged two critical 'Secret found: Private Key' findings on #159, at the SQ-OWN-10 row in the data file and in ADR 0004. Both were the owner hint that quoted the PEM header line. They are text, not a key, but the scanner cannot tell, and the hint does not need the literal header. The rows now say the key is the RSA PEM form the App settings page produces, not an OpenSSH key. No baseline or ignore entry was added. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
governance / UUID v7 conformance failed on #159: ./crates/squabble-core/src/rules.rs: non-v8 UUID literal. The SQ-OWN-14 log-signature test quoted the Apodeixis.jl run's real UUID. The matcher keys on the words 'non-v8 UUID literal', not on the value, so the test uses a <uuid> placeholder. No UUID literal remains in crates or docs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
…31 and shebang limit for SQ-CODE-03 Amendment 3 on top of #159 (stacked on its branch): - SQ-OWN-16 (OWNER, report only): a workflow force- or mirror-pushes to a forge gated on *_MIRROR_ENABLED with no source-visibility check (Hypatia WF030, static). Real example from the reconciliation thread: standards mirror-reusable.yml line 93 gate and line 144 git push --force gitlab main. The squabbler never edits a mirror workflow, pushes to a forge or changes a visibility setting. - SQ-RUN-03 also matches 'gh: Server Error (HTTP 5xx)': standards run 43446385277 logged 'gh: Server Error (HTTP 502)', which the 'gh: HTTP 5xx' matcher missed. A 404 in that form stays unmatched (test). - SQ-CODE-03 gains S131 (add a no-op *) ;; default, behaviour-neutral in shell) and the S7688 limits: [ ] to [[ ]] only in files with a bash shebang, refer when the test uses -a or -o or relies on word splitting. - ADR 0004: rows, mapping (mirror_without_visibility_guard), counts: 45 rules, 24 first-line. fmt, clippy -D warnings and the workspace tests pass (201 in squabble-core). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
…159) (#160) ## Summary Third ADR 0004 amendment, **stacked on #159**: the base is #159's branch, so this diff shows only the new commit. When #159 merges, GitHub retargets this PR to main. Review #159 first. Catalogue 44 to 45 rules (24 first-line, unchanged). ## Changes - **SQ-OWN-16** (OWNER, report only): a workflow force- or mirror-pushes to a forge gated on `*_MIRROR_ENABLED` with no source-visibility check (Hypatia WF030, found statically). Real example: standards `mirror-reusable.yml` line 93 gate, line 144 `git push --force gitlab main`. The squabbler never edits a mirror workflow, pushes to a forge or changes a visibility setting. - **SQ-RUN-03** also matches `gh: Server Error (HTTP 5xx)`. Standards run 43446385277 logged `gh: Server Error (HTTP 502)`, which my `gh: HTTP 5xx` matcher missed. A 404 in that form stays unmatched (tested). - **SQ-CODE-03** gains Sonar S131 (a no-op `*) ;;` default, behaviour-neutral in shell) and the S7688 limits: `[ ]` to `[[ ]]` only in files with a bash shebang, and refer when the test uses `-a` or `-o` or relies on word splitting. Both from the rule reconciliation thread. - **ADR 0004**: rows, the `mirror_without_visibility_guard` mapping, and counts. ## RSR Quality Checklist ### Required - [x] No banned language patterns - [x] SPDX license header on the data file (CC-BY-SA-4.0) - [x] No secrets, credentials, or `.env` files included ### As Applicable - [x] Documentation updated ## Testing `cargo fmt --all --check`, `cargo clippy --workspace --all-targets -- -D warnings` and `cargo test --workspace` pass (201 in squabble-core). No UUID literal or key header in `crates` or `docs`. No executors in this PR. --- _Generated by [Claude Code](https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU)_
|



Summary
Second ADR 0004 amendment, from evidence the rule reconciliation thread sent with run URLs. Catalogue 39 to 44 rules (24 first-line).
Changes
misconfigured_toolingfor Bun;package-ecosystemnpm to bun for that directory only. MetaManifold-WebUI run 43225380901; fixed by hand in MetaManifold-WebUI#330. Its check (next Dependabot run) has not run yet and the row says so.kyaml-format: <file> is not KYAML(quintessence run 43156792336). The fix runsscripts/kyaml-format.sh <file>, named in the rule and never taken from the log; a missing mikefarahyqmeans the check did not run.GH013, with a test), a non-v8 UUID literal (the squabbler never mints or rewrites a UUID), and SonarNot authorized or organization not found(never skip the Sonar step). Runs: Apodeixis.jl 43257204071 and 43257204302, lithoglyph 43152462261.refs missing from the lockfile(this-ssg run 43156768667). The this-ssgslsa-github-generator@f7dd8c54case is in its refer-when until a live run provesgh actions-lockregenerates it.repository_map_stale(SQ-GEN-01) andgenerated_file_stale(a referral: the squabbler never runs a command named in a log).RSR Quality Checklist
Required
.envfiles includedAs Applicable
Testing
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspacepass (201 in squabble-core). New cases use the real log lines from the runs above. No executors in this PR.https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
Generated by Claude Code