Skip to content

feat(rules): SQ-TOOL-02, SQ-GEN-04, SQ-OWN-13..15 and refs-missing for SQ-LOCK-02 - #159

Merged
hyperpolymath merged 6 commits into
mainfrom
claude/rules-amendment-2
Nov 13, 2026
Merged

hyperpolymath merged 6 commits into
mainfrom
claude/rules-amendment-2

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

Second ADR 0004 amendment, from evidence the rule reconciliation thread sent with run URLs. Catalogue 39 to 44 rules (24 first-line).

Changes

  • SQ-TOOL-02 (FIX, config only): Dependabot misconfigured_tooling for Bun; package-ecosystem npm to bun for that directory only. MetaManifold-WebUI run 43225380901; fixed by hand in MetaManifold-WebUI#330. Its check (next Dependabot run) has not run yet and the row says so.
  • SQ-GEN-04 (FIX): kyaml-format: <file> is not KYAML (quintessence run 43156792336). The fix runs scripts/kyaml-format.sh <file>, named in the rule and never taken from the log; a missing mikefarah yq means the check did not run.
  • SQ-OWN-13, 14, 15 (OWNER): a ruleset refusing a workflow push (gh API form; disjoint from SQ-OWN-04's GH013, with a test), a non-v8 UUID literal (the squabbler never mints or rewrites a UUID), and Sonar Not authorized or organization not found (never skip the Sonar step). Runs: Apodeixis.jl 43257204071 and 43257204302, lithoglyph 43152462261.
  • SQ-LOCK-02: also matches refs missing from the lockfile (this-ssg run 43156768667). The this-ssg slsa-github-generator@f7dd8c54 case is in its refer-when until a live run proves gh actions-lock regenerates it.
  • ADR 0004 mapping table: the new Hypatia ids, repository_map_stale (SQ-GEN-01) and generated_file_stale (a referral: the squabbler never runs a command named in a log).

RSR Quality Checklist

Required

  • No banned language patterns
  • SPDX license header on the data file (CC-BY-SA-4.0)
  • No secrets, credentials, or .env files included

As Applicable

  • Documentation updated

Testing

cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings and cargo test --workspace pass (201 in squabble-core). New cases use the real log lines from the runs above. No executors in this PR.

https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU


Generated by Claude Code

…ng signature for SQ-LOCK-02

Evidence from the rule reconciliation thread, with run URLs:

- SQ-TOOL-02 (40th rule, FIX, config only): Dependabot misconfigured_tooling
  for Bun. MetaManifold-WebUI run 43225380901 /frontend; fixed by hand in
  MetaManifold-WebUI#330 (package-ecosystem npm to bun, one directory, other
  entries unchanged). Refers when the directory has a second lockfile or the
  repository has no matching ecosystem. Its check (the next Dependabot run)
  has not run yet for #330 and the row says so.
- SQ-LOCK-02 also matches 'refs missing from the lockfile' (this-ssg run
  43156768667). The this-ssg slsa-github-generator@f7dd8c54 case is listed in
  its refer-when: gh actions-lock is not yet shown to regenerate it, so the
  guard sends it to a referral until a live run proves it.
- ADR 0004 mapping table: dependabot_ecosystem_mismatch, actions_lock_missing_ref,
  repository_map_stale (SQ-GEN-01) and generated_file_stale (referral).

fmt, clippy -D warnings and the workspace tests pass (200 in squabble-core).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • New Features
    • Added 13 rules covering additional dependency, formatting, repository, UUID, authorization and workflow issues.
    • Added recognition for more lockfile and Dependabot messages, server errors, KYAML failures, and repository rule violations.
    • Git and API push refusals are now identified separately.
  • Documentation
    • Expanded the rule catalogue and updated its counts and guidance, including information on lock references, workflow errors and code-quality findings.

The rule catalogue expands to 45 entries. The changes add runtime signatures and tests, revise guidance for existing rules, add owner-only rules, and update Hypatia mappings and catalogue totals.

Changes: Rule catalogue expansion

Layer / File(s) Summary
Rule definitions and guidance
docs/decisions/0004-first-line-rule-catalogue.adoc
The decision record adds rule guidance for Dependabot Bun mismatches, KYAML failures, and owner actions. It also updates guidance for lock references, transient server errors, shell checks, and RSA key reporting.
Runtime matchers and tests
crates/squabble-core/src/rules.rs
Runtime matchers recognise additional lockfile, Dependabot, server-error, KYAML, and owner-action signatures. Tests cover the new signatures, catalogue distinctions, and catalogue counts.
Hypatia mappings and catalogue totals
docs/decisions/0004-first-line-rule-catalogue.adoc, crates/squabble-core/src/rules.rs
Hypatia mappings and catalogue totals reflect the added and revised rules. The catalogue now records 45 entries, including 20 Fix rules and 16 Owner rules.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Suggested reviewers: claude

Merge Risk: Minimal · up to b0281

The change adds and updates rule signatures and catalogue documentation. The catalogue file parses cleanly, and no concrete merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the rule additions (SQ-TOOL-02, SQ-GEN-04, SQ-OWN-13..15) and the refs-missing signature for SQ-LOCK-02. These match the main changes in the description and the rules.rs summary. Howev…
Description check Passed The description follows the required template. It has Summary, Changes, RSR Quality Checklist, and Testing sections, and it keeps the checklist items. It explains each rule change, gives run reference…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the rule additions (SQ-TOOL-02, SQ-GEN-04, SQ-OWN-13..15) and the refs-missing signature for SQ-LOCK-02. These match the main changes in the description and the rules.rs summary. However, the title is a dense list of rule IDs and does not say these are new rule entries and signatures. It also omits the ADR amendment. The raw summary and objectives also describe a later amendment that adds SQ-OWN-16 and changes the rule count to 45, which the title does not cover. The title is related to the change but is not fully clear, so it passes with a note.

Full details: Description check

Explanation

The description follows the required template. It has Summary, Changes, RSR Quality Checklist, and Testing sections, and it keeps the checklist items. It explains each rule change, gives run references, and reports the test results. Several template items are not ticked or addressed: the Required checklist does not tick tests, formatting, or linter items in the list, though the Testing section reports they pass. The As Applicable items for STATE.a2ml, CHANGELOG, and ECOSYSTEM are not addressed. The description does not mention SQ-OWN-16 or the 45-rule count, which the later commits add. The description is mostly complete and passes.

Resolution

Optionally: tick the Required checks that the Testing section reports as passing, state whether the STATE.a2ml or CHANGELOG items apply, and align the rule count (44 in the description, 45 in later commits) with the SQ-OWN-16 amendment.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8bc96ee7-e2d2-4c68-badb-0cdd787397fd
Commits

Reviewing files that changed from the base of the PR and between aa591b3 and b0281c5.

Files ignored due to path filters: 1

  • crates/squabble-core/data/first-line-rules.tsv is excluded by !**/*.tsv
Files selected for processing: 2

  • crates/squabble-core/src/rules.rs
  • docs/decisions/0004-first-line-rule-catalogue.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 2

  • GitHub Check: pipeline / Pipeline report
  • GitHub Check: CodeRabbit
Additional context used

Code guidelines: 1

CLAUDE.md — auto-discovered
Path-based instructions: 1

Source excerpt: **Fail loudly, seal soundly** — no silent green; seams (ABI/FFI) sealed & proven.

CodeRabbit inference engine (CLAUDE.md)

Files:

  • crates/squabble-core/src/rules.rs
  • docs/decisions/0004-first-line-rule-catalogue.adoc

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T14:15:15.862118Z
We couldn’t complete this review. Comment @codex review to try again.
cfda602 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

…p evidence

Evidence from the rule reconciliation thread, with run URLs:

- SQ-GEN-04 (FIX): 'kyaml-format: <file> is not KYAML' (quintessence run
  43156792336). Fix is scripts/kyaml-format.sh <file>, named in the rule and
  never taken from the log; needs mikefarah Go yq, and a missing yq means the
  check did not run.
- SQ-OWN-13 (OWNER): 'gh: Repository rule violations found ... (HTTP 409)'
  (Apodeixis.jl run 43257204071). Disjoint from SQ-OWN-04 (the git GH013
  form); a test pins that neither claims the other.
- SQ-OWN-14 (OWNER): 'non-v8 UUID literal' / 'UUID check failed' (Apodeixis.jl
  run 43257204302). The squabbler never mints or rewrites a UUID.
- SQ-OWN-15 (OWNER): Sonar 'Not authorized or organization not found'
  (lithoglyph run 43152462261). Never skip the Sonar step.
- ADR 0004: rows, mapping table, counts (44 rules, 24 first-line).

fmt, clippy -D warnings and the workspace tests pass (201 in squabble-core).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
@hyperpolymath hyperpolymath changed the title feat(rules): SQ-TOOL-02 (Dependabot bun ecosystem) and refs-missing for SQ-LOCK-02 feat(rules): SQ-TOOL-02, SQ-GEN-04, SQ-OWN-13..15 and refs-missing for SQ-LOCK-02 Nov 13, 2026
…0 text

Hypatia's secret scan flagged two critical 'Secret found: Private Key'
findings on #159, at the SQ-OWN-10 row in the data file and in ADR 0004. Both
were the owner hint that quoted the PEM header line. They are text, not a
key, but the scanner cannot tell, and the hint does not need the literal
header. The rows now say the key is the RSA PEM form the App settings page
produces, not an OpenSSH key. No baseline or ignore entry was added.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
governance / UUID v7 conformance failed on #159: ./crates/squabble-core/src/rules.rs: non-v8 UUID literal. The SQ-OWN-14 log-signature test quoted the Apodeixis.jl run's real UUID. The matcher keys on the words 'non-v8 UUID literal', not on the value, so the test uses a <uuid> placeholder. No UUID literal remains in crates or docs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
…31 and shebang limit for SQ-CODE-03

Amendment 3 on top of #159 (stacked on its branch):

- SQ-OWN-16 (OWNER, report only): a workflow force- or mirror-pushes to a forge
  gated on *_MIRROR_ENABLED with no source-visibility check (Hypatia WF030, static).
  Real example from the reconciliation thread: standards mirror-reusable.yml line
  93 gate and line 144 git push --force gitlab main. The squabbler never edits a
  mirror workflow, pushes to a forge or changes a visibility setting.
- SQ-RUN-03 also matches 'gh: Server Error (HTTP 5xx)': standards run
  43446385277 logged 'gh: Server Error (HTTP 502)', which the 'gh: HTTP 5xx'
  matcher missed. A 404 in that form stays unmatched (test).
- SQ-CODE-03 gains S131 (add a no-op *) ;; default, behaviour-neutral in shell) and
  the S7688 limits: [ ] to [[ ]] only in files with a bash shebang, refer when the
  test uses -a or -o or relies on word splitting.
- ADR 0004: rows, mapping (mirror_without_visibility_guard), counts: 45 rules, 24
  first-line.

fmt, clippy -D warnings and the workspace tests pass (201 in squabble-core).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
…159) (#160)

## Summary

Third ADR 0004 amendment, **stacked on #159**: the base is #159's
branch, so this diff shows only the new commit. When #159 merges, GitHub
retargets this PR to main. Review #159 first. Catalogue 44 to 45 rules
(24 first-line, unchanged).

## Changes

- **SQ-OWN-16** (OWNER, report only): a workflow force- or mirror-pushes
to a forge gated on `*_MIRROR_ENABLED` with no source-visibility check
(Hypatia WF030, found statically). Real example: standards
`mirror-reusable.yml` line 93 gate, line 144 `git push --force gitlab
main`. The squabbler never edits a mirror workflow, pushes to a forge or
changes a visibility setting.
- **SQ-RUN-03** also matches `gh: Server Error (HTTP 5xx)`. Standards
run 43446385277 logged `gh: Server Error (HTTP 502)`, which my `gh: HTTP
5xx` matcher missed. A 404 in that form stays unmatched (tested).
- **SQ-CODE-03** gains Sonar S131 (a no-op `*) ;;` default,
behaviour-neutral in shell) and the S7688 limits: `[ ]` to `[[ ]]` only
in files with a bash shebang, and refer when the test uses `-a` or `-o`
or relies on word splitting. Both from the rule reconciliation thread.
- **ADR 0004**: rows, the `mirror_without_visibility_guard` mapping, and
counts.

## RSR Quality Checklist

### Required

- [x] No banned language patterns
- [x] SPDX license header on the data file (CC-BY-SA-4.0)
- [x] No secrets, credentials, or `.env` files included

### As Applicable

- [x] Documentation updated

## Testing

`cargo fmt --all --check`, `cargo clippy --workspace --all-targets -- -D
warnings` and `cargo test --workspace` pass (201 in squabble-core). No
UUID literal or key header in `crates` or `docs`. No executors in this
PR.

---
_Generated by [Claude
Code](https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU)_
@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 09e6790 into main Nov 13, 2026
72 checks passed
@hyperpolymath
hyperpolymath deleted the claude/rules-amendment-2 branch November 13, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants