Repository navigation
feat(rules): SQ-OWN-16 (WF030), gh Server Error 5xx, S131 (stacked on #159) - #160
Conversation
…31 and shebang limit for SQ-CODE-03 Amendment 3 on top of #159 (stacked on its branch): - SQ-OWN-16 (OWNER, report only): a workflow force- or mirror-pushes to a forge gated on *_MIRROR_ENABLED with no source-visibility check (Hypatia WF030, static). Real example from the reconciliation thread: standards mirror-reusable.yml line 93 gate and line 144 git push --force gitlab main. The squabbler never edits a mirror workflow, pushes to a forge or changes a visibility setting. - SQ-RUN-03 also matches 'gh: Server Error (HTTP 5xx)': standards run 43446385277 logged 'gh: Server Error (HTTP 502)', which the 'gh: HTTP 5xx' matcher missed. A 404 in that form stays unmatched (test). - SQ-CODE-03 gains S131 (add a no-op *) ;; default, behaviour-neutral in shell) and the S7688 limits: [ ] to [[ ]] only in files with a bash shebang, refer when the test uses -a or -o or relies on word splitting. - ADR 0004: rows, mapping (mirror_without_visibility_guard), counts: 45 rules, 24 first-line. fmt, clippy -D warnings and the workspace tests pass (201 in squabble-core). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|



Summary
Third ADR 0004 amendment, stacked on #159: the base is #159's branch, so this diff shows only the new commit. When #159 merges, GitHub retargets this PR to main. Review #159 first. Catalogue 44 to 45 rules (24 first-line, unchanged).
Changes
*_MIRROR_ENABLEDwith no source-visibility check (Hypatia WF030, found statically). Real example: standardsmirror-reusable.ymlline 93 gate, line 144git push --force gitlab main. The squabbler never edits a mirror workflow, pushes to a forge or changes a visibility setting.gh: Server Error (HTTP 5xx). Standards run 43446385277 loggedgh: Server Error (HTTP 502), which mygh: HTTP 5xxmatcher missed. A 404 in that form stays unmatched (tested).*) ;;default, behaviour-neutral in shell) and the S7688 limits:[ ]to[[ ]]only in files with a bash shebang, and refer when the test uses-aor-oor relies on word splitting. Both from the rule reconciliation thread.mirror_without_visibility_guardmapping, and counts.RSR Quality Checklist
Required
.envfiles includedAs Applicable
Testing
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspacepass (201 in squabble-core). No UUID literal or key header incratesordocs. No executors in this PR.Generated by Claude Code