Skip to content

feat(rules): SQ-OWN-16 (WF030), gh Server Error 5xx, S131 (stacked on #159) - #160

Merged
hyperpolymath merged 1 commit into
claude/rules-amendment-2from
claude/rules-amendment-3
Nov 13, 2026
Merged

hyperpolymath merged 1 commit into
claude/rules-amendment-2from
claude/rules-amendment-3

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Third ADR 0004 amendment, stacked on #159: the base is #159's branch, so this diff shows only the new commit. When #159 merges, GitHub retargets this PR to main. Review #159 first. Catalogue 44 to 45 rules (24 first-line, unchanged).

Changes

  • SQ-OWN-16 (OWNER, report only): a workflow force- or mirror-pushes to a forge gated on *_MIRROR_ENABLED with no source-visibility check (Hypatia WF030, found statically). Real example: standards mirror-reusable.yml line 93 gate, line 144 git push --force gitlab main. The squabbler never edits a mirror workflow, pushes to a forge or changes a visibility setting.
  • SQ-RUN-03 also matches gh: Server Error (HTTP 5xx). Standards run 43446385277 logged gh: Server Error (HTTP 502), which my gh: HTTP 5xx matcher missed. A 404 in that form stays unmatched (tested).
  • SQ-CODE-03 gains Sonar S131 (a no-op *) ;; default, behaviour-neutral in shell) and the S7688 limits: [ ] to [[ ]] only in files with a bash shebang, and refer when the test uses -a or -o or relies on word splitting. Both from the rule reconciliation thread.
  • ADR 0004: rows, the mirror_without_visibility_guard mapping, and counts.

RSR Quality Checklist

Required

  • No banned language patterns
  • SPDX license header on the data file (CC-BY-SA-4.0)
  • No secrets, credentials, or .env files included

As Applicable

  • Documentation updated

Testing

cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings and cargo test --workspace pass (201 in squabble-core). No UUID literal or key header in crates or docs. No executors in this PR.


Generated by Claude Code

…31 and shebang limit for SQ-CODE-03

Amendment 3 on top of #159 (stacked on its branch):

- SQ-OWN-16 (OWNER, report only): a workflow force- or mirror-pushes to a forge
  gated on *_MIRROR_ENABLED with no source-visibility check (Hypatia WF030, static).
  Real example from the reconciliation thread: standards mirror-reusable.yml line
  93 gate and line 144 git push --force gitlab main. The squabbler never edits a
  mirror workflow, pushes to a forge or changes a visibility setting.
- SQ-RUN-03 also matches 'gh: Server Error (HTTP 5xx)': standards run
  43446385277 logged 'gh: Server Error (HTTP 502)', which the 'gh: HTTP 5xx'
  matcher missed. A 404 in that form stays unmatched (test).
- SQ-CODE-03 gains S131 (add a no-op *) ;; default, behaviour-neutral in shell) and
  the S7688 limits: [ ] to [[ ]] only in files with a bash shebang, refer when the
  test uses -a or -o or relies on word splitting.
- ADR 0004: rows, mapping (mirror_without_visibility_guard), counts: 45 rules, 24
  first-line.

fmt, clippy -D warnings and the workspace tests pass (201 in squabble-core).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zmiut2nCcbtEx25HAU
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 26a7943d-7bfd-4f97-98e1-4906284a7a74

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T15:00:49.448161Z
We couldn’t complete this review. Comment @codex review to try again.
42cd821 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit b0281c5 into claude/rules-amendment-2 Nov 13, 2026
46 checks passed
@hyperpolymath
hyperpolymath deleted the claude/rules-amendment-3 branch November 13, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants