chore(affine-vscode): finish PMPL→MPL sweep + truth-up Status paragraph (Refs #104)#316
Merged
Merged
Conversation
…ph (Refs #104) Two stale license fields slipped past commit 3170a6b (the repo-wide PMPL-1.0-or-later → MPL-2.0 SPDX sweep, Closes #301): * packages/affine-vscode/package.json:6 * packages/affine-vscode/deno.json:7 mod.js + README.adoc already carry the right SPDX header, the publish workflow already does, and the OCaml-side LICENSE is MPL-2.0 — these two manifests were the only out-of-band sites. While here, refresh the README "Status" paragraph: the "long-term plan is to publish to npm so consumers do not have to vendor mod.js" framing is stale because affine-vscode-publish.yml has landed; the npm wiring is in place and the only remaining work tracked by #104 is the first publish + consumer-side un-vendoring in my-lang and standards rsr-certifier. No JS / OCaml / dune changes — manifest + doc only. Refs #104 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 21, 2026
hyperpolymath
added a commit
to hyperpolymath/standards
that referenced
this pull request
May 21, 2026
…ath/affinescript#104) (#160) ## Summary - Replace the 463-line in-tree copy of `rsr-certifier/extensions/vscode/src/affine-vscode-adapter.cjs` with a `require("@hyperpolymath/affine-vscode")` against the published npm package. - `src/index.cjs` line 18 swap + accompanying comment-block update. - `out/extension.cjs` is unchanged — this extension uses the manual-wiring pattern (`src/index.cjs` as the extension's `main`), so only the hand-written entry-point needs touching, not the AffineScript-compiled wasm shim. ## DRAFT — gated on hyperpolymath/affinescript#104 This PR cannot be marked ready-for-review until the package is on npm. Current state of affinescript#104: | Acceptance criterion | Status | |---|---| | `package.json` shape, peer deps, `repository.directory` | ✅ on `affinescript/main` | | CI tag-driven publish | ✅ `affine-vscode-publish.yml` on `affinescript/main` | | README documents npm-install as primary | ✅ on `affinescript/main` (tightened in hyperpolymath/affinescript#316) | | `npm view @hyperpolymath/affine-vscode` resolves | ❌ owner action: create npm org `hyperpolymath`, add `NPM_TOKEN` secret to affinescript repo, push tag `affine-vscode-v0.1.0` | | my-lang + standards un-vendored | 🟡 **this PR** (DRAFT) + companion DRAFT in hyperpolymath/my-lang#66 | ## Test plan After hyperpolymath/affinescript#104 lands the first publish: - [ ] `npm install` in `rhodium-standard-repositories/satellites/rsr-certifier/extensions/vscode/` resolves the new dep - [ ] Loading the extension in a fresh VS Code instance: `activate` runs without error, `rsr.checkCompliance` is registered, `deactivate` tears down cleanly - [ ] Mark this PR ready-for-review, then merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/affine-vscode/package.jsonline 6 andpackages/affine-vscode/deno.jsonline 7 still readPMPL-1.0-or-later; commit3170a6b(Closes Wider PMPL → MPL-2.0 relicense — decision needed #301) swept this everywhere else. This finishes the sweep.affine-vscode-publish.ymlis already in place, so the "long-term plan is to publish to npm so consumers do not have to vendormod.js" framing is stale.No JS / OCaml / dune changes — manifests + one doc paragraph.
Why this is not a full #104 closer
Issue #104's acceptance criteria are 4 bullets. After this PR:
package.jsonexists withname/main/peerDependencies/repository.directorymainaffine-vscode-publish.ymlalready onmain(trigger:affine-vscode-v*)main(Install + Usage), tightened here@hyperpolymath/affine-vscoderesolvable vianpm view@hyperpolymathorg doesn't yet exist on npm)So #104 stays open until the first tag push + downstream un-vendoring.
Test plan
gh pr viewshows green CI (manifest+doc-only changes; the heavy OCaml jobs inci.ymlare unaffected)cat packages/affine-vscode/package.json | jq -r .licensereturnsMPL-2.0cat packages/affine-vscode/deno.json | jq -r .licensereturnsMPL-2.0Refs #104
🤖 Generated with Claude Code