chore(rsr-certifier/vscode): un-vendor affine-vscode (Refs hyperpolymath/affinescript#104)#160
Merged
Merged
Conversation
…perpolymath/affinescript#104) Replace the in-tree 463-line copy of `rsr-certifier/extensions/vscode/src/affine-vscode-adapter.cjs` (verbatim copy of `packages/affine-vscode/mod.js` in hyperpolymath/affinescript at issue #64 fork point) with the published `@hyperpolymath/affine-vscode` npm package. Concrete edits, all confined to `rhodium-standard-repositories/satellites/rsr-certifier/extensions/vscode/`: * package.json: add `@hyperpolymath/affine-vscode@^0.1.0` to `dependencies`. * src/index.cjs line 18: `require("./affine-vscode-adapter.cjs")` → `require("@hyperpolymath/affine-vscode")`. Comment block above also updated: "vendored" → "published @hyperpolymath/affine-vscode". * src/affine-vscode-adapter.cjs: deleted (-463 lines). `out/extension.cjs` is unchanged — this extension uses the manual-wiring pattern (`src/index.cjs` as the extension's `main`, calls the adapter factory after requiring the compiled wasm shim), so only the entry-point hand-written file needs touching. # DRAFT — gated on hyperpolymath/affinescript#104 (npm first publish) Do NOT merge until `npm view @hyperpolymath/affine-vscode` resolves. Until then `npm install` here will 404. The PR is staged so the diff is reviewable in isolation from the publish step. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rsr-certifier/extensions/vscode/src/affine-vscode-adapter.cjswith arequire("@hyperpolymath/affine-vscode")against the published npm package.src/index.cjsline 18 swap + accompanying comment-block update.out/extension.cjsis unchanged — this extension uses the manual-wiring pattern (src/index.cjsas the extension'smain), so only the hand-written entry-point needs touching, not the AffineScript-compiled wasm shim.DRAFT — gated on hyperpolymath/affinescript#104
This PR cannot be marked ready-for-review until the package is on npm. Current state of affinescript#104:
package.jsonshape, peer deps,repository.directoryaffinescript/mainaffine-vscode-publish.ymlonaffinescript/mainaffinescript/main(tightened in hyperpolymath/affinescript#316)npm view @hyperpolymath/affine-vscoderesolveshyperpolymath, addNPM_TOKENsecret to affinescript repo, push tagaffine-vscode-v0.1.0Test plan
After hyperpolymath/affinescript#104 lands the first publish:
npm installinrhodium-standard-repositories/satellites/rsr-certifier/extensions/vscode/resolves the new depactivateruns without error,rsr.checkComplianceis registered,deactivatetears down cleanly🤖 Generated with Claude Code