Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/dogfood-gate.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This workflow is managed by gh actions-lock.

Check warning on line 1 in .github/workflows/dogfood-gate.yml

View workflow job for this annotation

GitHub Actions / Hypatia neurosymbolic scan

[hypatia] Job `rsr-score-self` in dogfood-gate.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).
# SPDX-License-Identifier: MPL-2.0
# This workflow is managed by gh actions-lock.
# Copyright (c) 2026 Jonathan D.A. Jewell (hyperpolymath) <j.d.a.jewell@open.ac.uk>
Expand Down Expand Up @@ -404,12 +404,18 @@
# ephemeral MERGE commit, which is not on the remote and would 404.
# The event's head sha is the commit that actually exists there.
HEAD_SHA: ${{ github.event.pull_request.head.sha || github.sha }}
# The repository that owns HEAD_SHA: the PR's head repo (a fork's commit
# is not on the base repo), else this repo. It was hard-coded to
# hyperpolymath/rsr-template-repo, so in every repo minted from the
# template the SHA 404ed there and the job always failed with
# "no rsr-profile.a2ml" no matter what the profile said.
HEAD_REPO: ${{ github.event.pull_request.head.repo.full_name || github.repository }}
run: |
set -euo pipefail
PROFILE="$RUNNER_TEMP/rsr-profile.a2ml"
fetched=""
for p in ".machine_readable/rsr-profile.a2ml" "machine-readable/rsr-profile.a2ml"; do
URL="https://raw.githubusercontent.com/hyperpolymath/rsr-template-repo/${HEAD_SHA}/${p}"
URL="https://raw.githubusercontent.com/${HEAD_REPO}/${HEAD_SHA}/${p}"
if curl -fsSL --retry 3 --max-time 30 "$URL" -o "$PROFILE" 2>/dev/null; then
Comment on lines +418 to 419

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Authenticate profile fetches for private repositories

When a minted repository remains private—as explicitly allowed by .github/settings.yml—this anonymous raw.githubusercontent.com request returns 404 even though the workflow has contents: read. Consequently, pushes and same-repository PRs still fail with no rsr-profile.a2ml in private repositories, so the new repository-aware URL does not fix the gate for that supported visibility; pass github.token in an authorization header or fetch the commit through authenticated Git instead.

Useful? React with 👍 / 👎.

fetched="$p"; break
fi
Expand Down Expand Up @@ -587,7 +593,7 @@
*Dogfooding is guinea pig fooding — we test our tools on ourselves.*
EOF

rsr-score-self:

Check warning on line 596 in .github/workflows/dogfood-gate.yml

View workflow job for this annotation

GitHub Actions / Hypatia neurosymbolic scan

[hypatia] workflow .github/workflows/dogfood-gate.yml:596 job `rsr-score-self` has no `timeout-minutes:` — defaults to 360 min on hang
name: RSR oracle — dogfood this repo
runs-on: ubuntu-latest
steps:
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ https://semver.org/spec/v2.0.0.html[Semantic Versioning].

==== Fixed

* `dogfood-gate.yml` Canon lockstep fetched the profile from
`hyperpolymath/rsr-template-repo/${HEAD_SHA}` instead of this repository, so in
every minted repo the commit 404ed and the job failed with "no rsr-profile.a2ml"
whatever the profile said. It now reads `${HEAD_REPO}` (the PR head repository,
else this one). The job still fails, now for the true reason: the declared
`[canon]` pin is behind the canon (see the pull request).
* `julia-ci.yml` Format step: it called `filter` over an uncollected
`Iterators.Flatten` (a `MethodError`), used `format_string` (not in
JuliaFormatter 2), and read every file in `src/`, including
Expand Down
Loading