Repository navigation
ci: make Canon lockstep read this repository's profile, not the template's - #18
Conversation
…ate's The job fetched .machine_readable/rsr-profile.a2ml from hyperpolymath/rsr-template-repo at the PR head SHA. In a minted repo that SHA does not exist there, so the job failed with 'no rsr-profile.a2ml' on every run. Read the head repository instead. Verified by running the step script against main: the template URL reproduces the CI error; the repo URL reads the profile and reports the real pin state. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Keep both changelog entries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Keep both changelog entries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Keep both changelog entries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e37318c5c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| URL="https://raw.githubusercontent.com/${HEAD_REPO}/${HEAD_SHA}/${p}" | ||
| if curl -fsSL --retry 3 --max-time 30 "$URL" -o "$PROFILE" 2>/dev/null; then |
There was a problem hiding this comment.
Authenticate profile fetches for private repositories
When a minted repository remains private—as explicitly allowed by .github/settings.yml—this anonymous raw.githubusercontent.com request returns 404 even though the workflow has contents: read. Consequently, pushes and same-repository PRs still fail with no rsr-profile.a2ml in private repositories, so the new repository-aware URL does not fix the gate for that supported visibility; pass github.token in an authorization header or fetch the commit through authenticated Git instead.
Useful? React with 👍 / 👎.



Summary
Canon lockstepfails on every PR, onmain, withno rsr-profile.a2ml at <sha>. Root cause:dogfood-gate.ymlfetches.machine_readable/rsr-profile.a2mlfromhyperpolymath/rsr-template-repo/${HEAD_SHA}: the template's repository, not this one. In a minted repo the PR head SHA does not exist there, so the fetch 404s on every run regardless of the profile. The check is wrong (CI side), not the repo.Changes
dogfood-gate.yml: fetch from${HEAD_REPO}(the PR head repository, elsegithub.repository); a fork's commit is not on the base repo, so the head repo is the right owner.CHANGELOG.adoc: Fixed entry.Testing
I ran the real step script (extracted from the workflow) against
main's SHA with the livecanon.lock:HEAD_REPOhyperpolymath/rsr-template-repo(current)no rsr-profile.a2ml at e57738b(reproduces CI)hyperpolymath/CoprocessorRuntime.jl(this PR)What this does NOT fix (important)
With the right file read, the job now fails for the true reason, so it will stay red after this merges:
version2.1.52.1.1(✗)criteria_sha2566a5aa8857bd0d0d56a5aa8857bd0d0d5(✓)gates_sha2565c510bba025be718e70efd2f53c9445e(✗)Bringing
[canon]in.machine_readable/rsr-profile.a2mlup to those values asserts conformance to canon 2.1.5 and its new gates. I have not verified that conformance, and.a2mlis a retired format, so that re-pin is left for the owner's decision rather than done here.The same defect is almost certainly in
rsr-template-repo'sdogfood-gate.ymland every repo minted from it; the fix at source belongs there.Generated by Claude Code