Skip to content

ci: make Canon lockstep read this repository's profile, not the template's - #18

Merged
hyperpolymath merged 4 commits into
mainfrom
ci/canon-lockstep-own-repo
Nov 14, 2026
Merged

hyperpolymath merged 4 commits into
mainfrom
ci/canon-lockstep-own-repo

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Canon lockstep fails on every PR, on main, with no rsr-profile.a2ml at <sha>. Root cause: dogfood-gate.yml fetches .machine_readable/rsr-profile.a2ml from hyperpolymath/rsr-template-repo/${HEAD_SHA}: the template's repository, not this one. In a minted repo the PR head SHA does not exist there, so the fetch 404s on every run regardless of the profile. The check is wrong (CI side), not the repo.

Changes

  • dogfood-gate.yml: fetch from ${HEAD_REPO} (the PR head repository, else github.repository); a fork's commit is not on the base repo, so the head repo is the right owner.
  • CHANGELOG.adoc: Fixed entry.

Testing

I ran the real step script (extracted from the workflow) against main's SHA with the live canon.lock:

HEAD_REPO result
hyperpolymath/rsr-template-repo (current) no rsr-profile.a2ml at e57738b (reproduces CI)
hyperpolymath/CoprocessorRuntime.jl (this PR) reads the profile, then compares the pins

What this does NOT fix (important)

With the right file read, the job now fails for the true reason, so it will stay red after this merges:

pin canon.lock asserts this repo declares
version 2.1.5 2.1.1 (✗)
criteria_sha256 6a5aa8857bd0d0d5 6a5aa8857bd0d0d5 (✓)
gates_sha256 5c510bba025be718 e70efd2f53c9445e (✗)

Bringing [canon] in .machine_readable/rsr-profile.a2ml up to those values asserts conformance to canon 2.1.5 and its new gates. I have not verified that conformance, and .a2ml is a retired format, so that re-pin is left for the owner's decision rather than done here.

The same defect is almost certainly in rsr-template-repo's dogfood-gate.yml and every repo minted from it; the fix at source belongs there.


Generated by Claude Code

…ate's

The job fetched .machine_readable/rsr-profile.a2ml from
hyperpolymath/rsr-template-repo at the PR head SHA. In a minted repo that SHA
does not exist there, so the job failed with 'no rsr-profile.a2ml' on every run.
Read the head repository instead. Verified by running the step script against
main: the template URL reproduces the CI error; the repo URL reads the profile
and reports the real pin state.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 99501a88-44ae-46b8-a23d-a39810faa282
Commits

Reviewing files that changed from the base of the PR and between 3751191 and e37318c.

Files selected for processing: 2

  • .github/workflows/dogfood-gate.yml
  • CHANGELOG.adoc
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 14, 2026 16:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T17:56:38.839992Z e37318c New commits
🔒 Security Review ✅ Completed 2026-11-14T17:56:58.945541Z e37318c New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Keep both changelog entries.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Keep both changelog entries.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
Keep both changelog entries.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoXueEiNpcpgdeBR67
@hyperpolymath
hyperpolymath merged commit 0d5520c into main Nov 14, 2026
25 checks passed
@hyperpolymath
hyperpolymath deleted the ci/canon-lockstep-own-repo branch November 14, 2026 17:54
@sonarqubecloud

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e37318c5c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +418 to 419
URL="https://raw.githubusercontent.com/${HEAD_REPO}/${HEAD_SHA}/${p}"
if curl -fsSL --retry 3 --max-time 30 "$URL" -o "$PROFILE" 2>/dev/null; then

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Authenticate profile fetches for private repositories

When a minted repository remains private—as explicitly allowed by .github/settings.yml—this anonymous raw.githubusercontent.com request returns 404 even though the workflow has contents: read. Consequently, pushes and same-repository PRs still fail with no rsr-profile.a2ml in private repositories, so the new repository-aware URL does not fix the gate for that supported visibility; pass github.token in an authorization header or fetch the commit through authenticated Git instead.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants