You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
sdk/internal: use lexicon strongRef type and schema in resolveRecordRef - #4
resolveRecordRef defined its own StrongRef type and hand-checked the PDS response, waiting on @hypercerts-org/lexicon to publish record schemas. 2.0.1 now ships them.
Fix
StrongRef is now com.atproto.repo.strongRef's Main type from @hypercerts-org/lexicon.
The getRecord response is checked with that package's strongRef.main schema; the same-URI check stays. Error now reads "without a valid URI and CID".
@hypercerts-org/lexicon added as a peer dependency (^2.0.1), pinned as a dev dependency.
AGENTS.md validation notes updated to the real export layout.
Summary by CodeRabbit
Bug Fixes
Strong references are now checked for both a valid URI and CID, rather than validating only the CID.
Responses with invalid reference data or a URI that does not match the requested record now produce clearer error messages.
@hypercerts-org/lexicon 2.0.1 publishes record schemas, so the SDK no longer defines its own strong-ref shape or hand-checks the getRecord response. The package is added as a peer dependency.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 6a9c16bc-2188-4e7a-8e5a-97dfe22d9f90
Commits
Reviewing files that changed from the base of the PR and between cd0dadb and 79960dd.
Files selected for processing: 4
.github/workflows/ci.yml
AGENTS.md
README.md
package.json
No actionable comments were generated in the recent review.
Walkthrough
The SDK now uses the lexicon package’s strongRef.Main type and validates resolved record-reference responses against the com.atproto.repo.strongRef schema before comparing URIs. The package configuration, workspace settings, guidance, tests, and changeset are updated.
Changes: Lexicon Strong Reference Validation
Layer / File(s)
Summary
Lexicon dependency and strong-reference type packages/sdk/package.json, packages/sdk/src/internal/resolve-record-ref.ts, AGENTS.md, pnpm-workspace.yaml
The SDK adds @hypercerts-org/lexicon as a peer and development dependency. StrongRef now aliases strongRef.Main. Workspace release-age settings and SDK guidance are updated for the package.
resolveRecordRef validates the full response body against the strong-reference schema before checking its URI. Invalid bodies produce an error referring to both URI and CID; URI mismatches report the returned URI. Tests and the changeset reflect these updates.
hypercerts-org/sdk#3: Adds resolveRecordRef and the StrongRef interface that this change updates.
Merge Risk: Minimal · previous review cd0da
Record references use the lexicon schema without an identified material merge risk.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: resolveRecordRef in the SDK internals now uses the lexicon package's strongRef type and schema instead of a local StrongRef shape and hand-written checks. The raw summ…
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: resolveRecordRef in the SDK internals now uses the lexicon package's strongRef type and schema instead of a local StrongRef shape and hand-written checks. The raw summary confirms this change in resolve-record-ref.ts, with supporting changes to package.json, the changeset, and pnpm-workspace.yaml. The title is specific and matches the changeset.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files. (4 skipped: 4 unsupported.)
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
--similarity misses functions rewritten in a different style. jscpd --semantic compares embeddings from a local model; 0.55 catches hand-written rewrites of describe.ts helpers that the default 0.6375 misses, with no false matches in the SDK today. The model is cached in CI.
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.
What Enabling Code Scanning Means:
The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.
For more information about GitHub Code Scanning, check out the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to TECH-752 (TECH-750 is now released).
Problem
resolveRecordRefdefined its ownStrongReftype and hand-checked the PDS response, waiting on@hypercerts-org/lexiconto publish record schemas. 2.0.1 now ships them.Fix
StrongRefis nowcom.atproto.repo.strongRef'sMaintype from@hypercerts-org/lexicon.getRecordresponse is checked with that package'sstrongRef.mainschema; the same-URI check stays. Error now reads "without a valid URI and CID".@hypercerts-org/lexiconadded as a peer dependency (^2.0.1), pinned as a dev dependency.Summary by CodeRabbit