Repository navigation
feat(inference): show the task field for any policy not known to ignore it - #135
Open
ravediamond wants to merge 1 commit into
Open
ravediamond wants to merge 1 commit into
ravediamond wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the discussion on #114.
The inference dialog only showed the task field for a fixed list of four policy types (
smolvla,pi0,pi0_fast,pi05), so other language-conditioned policies (groot,xvla, plugin policies, ...) had no way to pass a task.Flip the check:
requires_taskis now true unless the policy type is known to ignore the task (act,diffusion,vqbet,tdmpc,sac). An unused task string is harmless, while a missing one makes a language-conditioned policy unusable. The field stays optional in the dialog.Backend only, so no
frontend/distchange. Added tests for the task-free, language-conditioned and unknown/missing type cases.🤖 Generated with Claude Code