Repository navigation
feat(cameras): support rotation across previews, recording, and inference - #123
Merged
nicolas-rabault merged 1 commit intoOct 9, 2026
Merged
Conversation
nicolas-rabault
force-pushed
the
feat/camera-rotation
branch
2 times, most recently
from
October 8, 2026 11:34
d23b09b to
7c47b78
Compare
nicolas-rabault
force-pushed
the
feat/camera-rotation
branch
from
October 8, 2026 12:43
7c47b78 to
7bc549b
Compare
nicolas-rabault
self-requested a review
October 9, 2026 07:52
nicolas-rabault
approved these changes
Oct 9, 2026
nicolas-rabault
left a comment
Member
There was a problem hiding this comment.
Well done @Hadrien-Cornier .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mounted my SO-101 wrist camera upside down. LeRobot supports image rotation, but LeLab does not expose or forward it. This adds a saved rotation control for each camera: 0°, 90°, 180°, or 270° clockwise.
The rotation applies to setup, teleoperation, and inference previews, saved recording frames, and inference camera input. Old profiles default to 0°. Invalid values produce a visible error and block recording or inference until corrected.
Capture dimensions remain native. A 640 × 480 capture at 90° produces a 480 × 640 observation. The adapters account for LeRobot v0.6.0 output dimensions and its signed rotation enum. Inference rotation follows the selected physical camera. Backend recording frames receive no second display rotation.
Users must select the same rotation as the training dataset. Checkpoint dimensions cannot establish image orientation. Existing recordings and checkpoints remain unchanged. Camera identity work in #119 stays separate.
Validation:
Full TypeScript reports five errors identical to unchanged main. Changed-source ESLint has no errors and two existing hook warnings. Physical camera behavior and a loaded policy remain unverified.
Reproduction scripts, logs, and screenshots.