Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/techdocs-cli-embedded-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: Critical version downgrade from workspace:^ (1.6.6-next.0) to 0.1.1, creating a major version mismatch that may cause runtime errors, dependency conflicts, and build failures.

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs": "workspace:^",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Breaking the established pattern of using workspace protocol for internal dependencies, creating maintenance overhead and potential version drift.

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs": "workspace:^",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security: Using an extremely old version (0.1.1 vs current 1.6.6) exposes the application to known vulnerabilities that have been fixed in newer versions.

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs": "workspace:^",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Deviation from the established monorepo dependency management strategy without clear justification, reducing maintainability and consistency.

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs": "workspace:^",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Missing context or explanation for why this specific version is needed, lacking documentation in commit message, PR description, or code comments.

"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^",
Expand Down
Loading