-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/plugin-techdocs from 0.0.0-use.local to 0.1.1 #6796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…abilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-DOMPURIFY-7984421
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Reviewer's GuideThis PR pins the @backstage/plugin-techdocs dependency to version 0.1.1 in package.json, replacing the local workspace reference to address a Prototype Pollution vulnerability flagged by Snyk. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
⛔ Snyk checks have failed. 85 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
🔒 Entelligence AI Vulnerability Scanner ✅ No security vulnerabilities found! Your code passed our comprehensive security analysis. |
WalkthroughThis PR updates the dependency configuration in the techdocs-cli-embedded-app package by pinning the '@backstage/plugin-techdocs' dependency to a specific version (0.1.1) instead of using a workspace reference. This change ensures that the embedded app uses a stable, known version of the techdocs plugin rather than potentially pulling in breaking changes from the latest workspace version. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
title TechDocs CLI Embedded App Dependency Resolution
participant User as "Developer"
participant PM as "Package Manager (npm/yarn)"
participant App as "techdocs-cli-embedded-app"
participant Registry as "Package Registry"
participant TechDocs as "@backstage/plugin-techdocs"
participant OtherDeps as "Other Dependencies"
User->>PM: Install dependencies
activate PM
PM->>App: Read package.json
Note over App: Before: workspace reference<br>After: pinned to v0.1.1
PM->>Registry: Request @backstage/plugin-techdocs@0.1.1
Registry-->>PM: Return specific version 0.1.1
PM->>OtherDeps: Request workspace dependencies
OtherDeps-->>PM: Return latest workspace versions
PM-->>User: Dependencies installed
deactivate PM
Note over User,TechDocs: Impact: techdocs-cli-embedded-app<br>now uses a fixed version of the<br>TechDocs plugin instead of<br>the latest workspace version
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
|
LGTM 👍 |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
WalkthroughThis PR updates the dependency configuration in the techdocs-cli-embedded-app package by pinning the '@backstage/plugin-techdocs' dependency to a specific version (0.1.1) instead of using a workspace reference. This change ensures stability and compatibility by preventing automatic updates to newer workspace versions that might introduce breaking changes. The fixed version approach provides more predictable behavior for the techdocs-cli-embedded-app. Changes
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
|
LGTM 👍 |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
📝 WalkthroughThis PR modifies the dependency management approach in the This change represents a significant version downgrade from the current workspace version ( 📊 Changes
🔒 Security Highlights
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
title TechDocs CLI Embedded App Dependency Flow
participant User as "Developer/User"
participant CLI as "TechDocs CLI"
participant EmbeddedApp as "TechDocs CLI Embedded App"
participant TechDocsPlugin as "@backstage/plugin-techdocs"
participant OtherDeps as "Other Dependencies"
User->>CLI: Run TechDocs CLI command
activate CLI
CLI->>EmbeddedApp: Initialize embedded app
activate EmbeddedApp
Note over EmbeddedApp: Before: Using workspace reference<br>After: Using fixed version 0.1.1
EmbeddedApp->>TechDocsPlugin: Import and initialize
activate TechDocsPlugin
EmbeddedApp->>OtherDeps: Import and initialize other dependencies
activate OtherDeps
alt Using fixed version (0.1.1)
TechDocsPlugin-->>EmbeddedApp: Provide stable, known functionality
Note over TechDocsPlugin, EmbeddedApp: Ensures consistent behavior<br>regardless of workspace changes
else Using workspace reference
TechDocsPlugin-->>EmbeddedApp: Provide latest workspace version
Note over TechDocsPlugin, EmbeddedApp: May include latest changes<br>but potentially unstable
end
EmbeddedApp-->>CLI: Return initialized app
deactivate TechDocsPlugin
deactivate OtherDeps
CLI-->>User: Render TechDocs UI
deactivate EmbeddedApp
deactivate CLI
🔒 Security Analysis
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
| "@backstage/integration-react": "workspace:^", | ||
| "@backstage/plugin-catalog": "workspace:^", | ||
| "@backstage/plugin-techdocs": "workspace:^", | ||
| "@backstage/plugin-techdocs": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correctness: Critical version downgrade from workspace:^ (1.6.6-next.0) to 0.1.1, creating a major version mismatch that may cause runtime errors, dependency conflicts, and build failures.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| "@backstage/plugin-techdocs": "0.1.1", | |
| "@backstage/plugin-techdocs": "workspace:^", |
| "@backstage/integration-react": "workspace:^", | ||
| "@backstage/plugin-catalog": "workspace:^", | ||
| "@backstage/plugin-techdocs": "workspace:^", | ||
| "@backstage/plugin-techdocs": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style: Breaking the established pattern of using workspace protocol for internal dependencies, creating maintenance overhead and potential version drift.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| "@backstage/plugin-techdocs": "0.1.1", | |
| "@backstage/plugin-techdocs": "workspace:^", |
| "@backstage/integration-react": "workspace:^", | ||
| "@backstage/plugin-catalog": "workspace:^", | ||
| "@backstage/plugin-techdocs": "workspace:^", | ||
| "@backstage/plugin-techdocs": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security: Using an extremely old version (0.1.1 vs current 1.6.6) exposes the application to known vulnerabilities that have been fixed in newer versions.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| "@backstage/plugin-techdocs": "0.1.1", | |
| "@backstage/plugin-techdocs": "workspace:^", |
| "@backstage/integration-react": "workspace:^", | ||
| "@backstage/plugin-catalog": "workspace:^", | ||
| "@backstage/plugin-techdocs": "workspace:^", | ||
| "@backstage/plugin-techdocs": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style: Deviation from the established monorepo dependency management strategy without clear justification, reducing maintainability and consistency.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| "@backstage/plugin-techdocs": "0.1.1", | |
| "@backstage/plugin-techdocs": "workspace:^", |
| "@backstage/integration-react": "workspace:^", | ||
| "@backstage/plugin-catalog": "workspace:^", | ||
| "@backstage/plugin-techdocs": "workspace:^", | ||
| "@backstage/plugin-techdocs": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style: Missing context or explanation for why this specific version is needed, lacking documentation in commit message, PR description, or code comments.
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
WalkthroughThis pull request modifies the dependency management strategy for the techdocs-cli-embedded-app package. The change replaces the workspace protocol reference for the '@backstage/plugin-techdocs' dependency with a specific pinned version (0.1.1). This transition from a dynamic workspace reference to a fixed version number indicates a shift toward version stability and controlled dependency resolution. The modification likely supports scenarios such as preparing the package for publication, ensuring compatibility with specific plugin versions, or preventing unexpected breaking changes from workspace updates. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant CLI as techdocs-cli-embedded-app
participant PM as Package Manager
participant WS as Workspace (Local)
participant NPM as NPM Registry
Note over Dev,NPM: Before Change (workspace:^)
Dev->>PM: Install dependencies
PM->>CLI: Resolve @backstage/plugin-techdocs
CLI->>PM: Request workspace:^
PM->>WS: Fetch from local workspace
WS-->>PM: Return local package
PM-->>CLI: Link local dependency
Note over Dev,NPM: After Change (0.1.1)
Dev->>PM: Install dependencies
PM->>CLI: Resolve @backstage/plugin-techdocs
CLI->>PM: Request version 0.1.1
PM->>NPM: Fetch from registry
NPM-->>PM: Return published package v0.1.1
PM-->>CLI: Install npm dependency
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
WalkthroughThis pull request modifies the dependency management strategy for the techdocs-cli-embedded-app package. The change replaces the workspace protocol reference for the '@backstage/plugin-techdocs' dependency with a specific pinned version (0.1.1). This transition from a dynamic workspace reference to a fixed version number indicates a shift toward version stability and controlled dependency resolution. The modification likely supports scenarios such as preparing the package for publication, ensuring compatibility with specific plugin versions, or preventing unexpected breaking changes from workspace updates. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant CLI as techdocs-cli-embedded-app
participant PM as Package Manager
participant WS as Workspace (Local)
participant NPM as NPM Registry
Note over Dev,NPM: Before Change (workspace:^)
Dev->>PM: Install dependencies
PM->>CLI: Resolve @backstage/plugin-techdocs
CLI->>PM: Request workspace:^
PM->>WS: Fetch from local workspace
WS-->>PM: Return local package
PM-->>CLI: Link local dependency
Note over Dev,NPM: After Change (0.1.1)
Dev->>PM: Install dependencies
PM->>CLI: Resolve @backstage/plugin-techdocs
CLI->>PM: Request version 0.1.1
PM->>NPM: Fetch from registry
NPM-->>PM: Return published package v0.1.1
PM-->>CLI: Install npm dependency
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
WalkthroughThis pull request modifies the dependency management strategy for the techdocs-cli-embedded-app package. The change replaces the workspace protocol reference for the '@backstage/plugin-techdocs' dependency with a specific pinned version (0.1.1). This transition from a dynamic workspace reference to a fixed version number indicates a shift toward version stability and controlled dependency resolution. The modification likely supports scenarios such as preparing the package for publication, ensuring compatibility with specific plugin versions, or preventing unexpected breaking changes from workspace updates. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant CLI as techdocs-cli-embedded-app
participant PM as Package Manager
participant WS as Workspace (Local)
participant NPM as NPM Registry
Note over Dev,NPM: Before Change (workspace:^)
Dev->>PM: Install dependencies
PM->>CLI: Resolve @backstage/plugin-techdocs
CLI->>PM: Request workspace:^
PM->>WS: Fetch from local workspace
WS-->>PM: Return local package
PM-->>CLI: Link local dependency
Note over Dev,NPM: After Change (0.1.1)
Dev->>PM: Install dependencies
PM->>CLI: Resolve @backstage/plugin-techdocs
CLI->>PM: Request version 0.1.1
PM->>NPM: Fetch from registry
NPM-->>PM: Return published package v0.1.1
PM-->>CLI: Install npm dependency
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
WalkthroughThis pull request modifies the dependency management strategy for the techdocs-cli-embedded-app package. The change replaces the workspace protocol reference for the '@backstage/plugin-techdocs' dependency with a specific pinned version (0.1.1). This transition from a dynamic workspace reference to a fixed version number indicates a shift toward version stability and controlled dependency resolution. The modification ensures that the embedded app will consistently use version 0.1.1 of the techdocs plugin, which may be necessary for compatibility guarantees, production deployment requirements, or package publication preparation. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant Local as Local Workspace
participant Registry as NPM Registry
participant App as techdocs-cli-embedded-app
Note over Dev,App: Before: workspace:^ dependency
Dev->>PM: Install dependencies (before)
PM->>Local: Resolve @backstage/plugin-techdocs
Local-->>PM: Return local workspace version
PM->>App: Link local plugin-techdocs
Note over Dev,App: After: 0.1.1 specific version
Dev->>PM: Install dependencies (after)
PM->>Registry: Fetch @backstage/plugin-techdocs@0.1.1
Registry-->>PM: Return version 0.1.1
PM->>App: Install plugin-techdocs@0.1.1
Note over App: App now uses fixed version<br/>instead of local workspace
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
EntelligenceAI PR Summary
This PR pins the '@backstage/plugin-techdocs' dependency to a specific version in the techdocs-cli-embedded-app package.