Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/catalog-backend-module-puppetdb/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specified version 0.1.1 for @backstage/catalog-model is significantly outdated. Current Backstage packages typically use much higher version numbers (likely in the 1.x range). Replacing a workspace reference with such an old version will almost certainly cause compatibility issues with other Backstage components.

Consider using a more recent version that aligns with your other Backstage dependencies, or maintain the workspace reference if this is part of a monorepo setup. The same concern applies to the @backstage/plugin-catalog-node version.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/catalog-model": "^1.4.0",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing workspace references with fixed versions (0.1.1 for @backstage/catalog-model and 1.0.0 for @backstage/plugin-catalog-node) breaks the monorepo dependency management pattern used in Backstage.

Workspace references (workspace:^) ensure that compatible versions are used across the project and that local changes are immediately reflected. Fixed versions will:

  1. Prevent local development changes from propagating
  2. Potentially introduce version conflicts with other components
  3. Make it harder to maintain consistent dependency versions

Consider keeping the workspace references and instead updating the root dependencies to address the vulnerability. This maintains the monorepo integrity while still addressing the security issue.

Suggested change
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/plugin-catalog-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"lodash": "^4.17.21",
"luxon": "^3.0.0",
Expand Down
Loading