-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 1 vulnerabilities #4769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -50,10 +50,10 @@ | |||||
| "@backstage/backend-common": "workspace:^", | ||||||
| "@backstage/backend-plugin-api": "workspace:^", | ||||||
| "@backstage/backend-tasks": "workspace:^", | ||||||
| "@backstage/catalog-model": "workspace:^", | ||||||
| "@backstage/catalog-model": "0.1.1", | ||||||
| "@backstage/config": "workspace:^", | ||||||
| "@backstage/errors": "workspace:^", | ||||||
| "@backstage/plugin-catalog-node": "workspace:^", | ||||||
| "@backstage/plugin-catalog-node": "1.0.0", | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replacing workspace references with fixed versions ( Workspace references (
Consider keeping the workspace references and instead updating the root dependencies to address the vulnerability. This maintains the monorepo integrity while still addressing the security issue.
Suggested change
Spotted by Diamond |
||||||
| "@backstage/types": "workspace:^", | ||||||
| "lodash": "^4.17.21", | ||||||
| "luxon": "^3.0.0", | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specified version
0.1.1for@backstage/catalog-modelis significantly outdated. Current Backstage packages typically use much higher version numbers (likely in the 1.x range). Replacing a workspace reference with such an old version will almost certainly cause compatibility issues with other Backstage components.Consider using a more recent version that aligns with your other Backstage dependencies, or maintain the workspace reference if this is part of a monorepo setup. The same concern applies to the
@backstage/plugin-catalog-nodeversion.Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.