Skip to content

Conversation

@snyk-io
Copy link

@snyk-io snyk-io bot commented Apr 23, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/catalog-backend-module-puppetdb/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-OCTOKITREQUESTERROR-8730854
  666  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Summary by Sourcery

Update package dependencies to fix a security vulnerability in the catalog backend module

Bug Fixes:

  • Fix a Regular Expression Denial of Service (ReDoS) vulnerability in the project dependencies

Enhancements:

  • Update @backstage/catalog-model from workspace version to specific version 0.1.1
  • Update @backstage/plugin-catalog-node from workspace version to specific version 1.0.0

EntelligenceAI PR Summary

This PR pins Backstage catalog dependencies to explicit versions in the catalog-backend-module-puppetdb plugin, moving away from workspace protocol references.

  • Changed @backstage/catalog-model from workspace:^ to fixed version 0.1.1
  • Changed @backstage/plugin-catalog-node from workspace:^ to fixed version 1.0.0
  • Modified dependency specifications in plugins/catalog-backend-module-puppetdb/package.json
  • Indicates preparation for independent package publishing or resolution of version compatibility constraints

@codesandbox
Copy link

codesandbox bot commented Apr 23, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 23, 2025

Reviewer's Guide by Sourcery

This pull request updates the @backstage/catalog-model and @backstage/plugin-catalog-node dependencies in plugins/catalog-backend-module-puppetdb/package.json to address a Regular Expression Denial of Service (ReDoS) vulnerability. The versions were updated from workspace:^ to 0.1.1 and 1.0.0 respectively.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated @backstage/catalog-model and @backstage/plugin-catalog-node dependencies to address a Regular Expression Denial of Service (ReDoS) vulnerability.
  • Updated @backstage/catalog-model from workspace:^ to 0.1.1.
  • Updated @backstage/plugin-catalog-node from workspace:^ to 1.0.0.
plugins/catalog-backend-module-puppetdb/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@restack-app
Copy link

restack-app bot commented Apr 23, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, snyk-io[bot]!). We assume it knows what it's doing!
  • It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Apr 30, 2025
@github-actions github-actions bot closed this May 9, 2025
@snyk-io snyk-io bot reopened this May 18, 2025
@snyk-io
Copy link
Author

snyk-io bot commented May 18, 2025

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specified version 0.1.1 for @backstage/catalog-model is significantly outdated. Current Backstage packages typically use much higher version numbers (likely in the 1.x range). Replacing a workspace reference with such an old version will almost certainly cause compatibility issues with other Backstage components.

Consider using a more recent version that aligns with your other Backstage dependencies, or maintain the workspace reference if this is part of a monorepo setup. The same concern applies to the @backstage/plugin-catalog-node version.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/catalog-model": "^1.4.0",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing workspace references with fixed versions (0.1.1 for @backstage/catalog-model and 1.0.0 for @backstage/plugin-catalog-node) breaks the monorepo dependency management pattern used in Backstage.

Workspace references (workspace:^) ensure that compatible versions are used across the project and that local changes are immediately reflected. Fixed versions will:

  1. Prevent local development changes from propagating
  2. Potentially introduce version conflicts with other components
  3. Make it harder to maintain consistent dependency versions

Consider keeping the workspace references and instead updating the root dependencies to address the vulnerability. This maintains the monorepo integrity while still addressing the security issue.

Suggested change
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/plugin-catalog-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@socket-security
Copy link

socket-security bot commented May 18, 2025

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@github-actions github-actions bot removed the stale label May 19, 2025
@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 26, 2025
@github-actions github-actions bot closed this May 31, 2025
@snyk-io snyk-io bot reopened this Jul 9, 2025
@github-actions github-actions bot removed the stale label Jul 15, 2025
@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Aug 11, 2025
@github-actions github-actions bot closed this Aug 24, 2025
@snyk-io snyk-io bot reopened this Nov 25, 2025
@entelligence-ai-pr-reviews
Copy link

Entelligence AI Vulnerability Scanner

Status: No security vulnerabilities found

Your code passed our comprehensive security analysis.

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This pull request updates the dependency management strategy for the catalog-backend-module-puppetdb plugin by replacing workspace protocol references with explicit version pinning. Two Backstage catalog-related dependencies are affected: @backstage/catalog-model is now fixed at version 0.1.1 and @backstage/plugin-catalog-node at version 1.0.0. This transition from workspace:^ to specific version numbers suggests the package is being prepared for independent publication outside the monorepo context or addresses specific version compatibility requirements that necessitate locked dependency versions.

Changes

File(s) Summary
plugins/catalog-backend-module-puppetdb/package.json Replaced workspace protocol references with explicit version pinning for two dependencies: @backstage/catalog-model set to 0.1.1 and @backstage/plugin-catalog-node set to 1.0.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant WS as Workspace Registry
    participant NPM as NPM Registry
    participant Plugin as catalog-backend-module-puppetdb

    Dev->>PM: Update package.json dependencies
    Note over Dev,PM: Pin catalog-model to 0.1.1<br/>Pin plugin-catalog-node to 1.0.0
    
    Dev->>PM: Run install command
    PM->>NPM: Fetch @backstage/catalog-model@0.1.1
    NPM-->>PM: Return package
    PM->>NPM: Fetch @backstage/plugin-catalog-node@1.0.0
    NPM-->>PM: Return package
    
    PM->>Plugin: Install dependencies
    Plugin-->>PM: Dependencies installed
    PM-->>Dev: Installation complete
    
    Note over Plugin: Plugin now uses fixed versions<br/>instead of workspace references
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@github-actions github-actions bot removed the stale label Nov 27, 2025
@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Dec 23, 2025
@github-actions github-actions bot closed this Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant