-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 1 vulnerabilities #4769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-OCTOKITREQUESTERROR-8730854
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Reviewer's Guide by SourceryThis pull request updates the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. Here's why:
- It seems to have been created by a bot (hey, snyk-io[bot]!). We assume it knows what it's doing!
- It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
- We don't review packaging changes - Let us know if you'd like us to change this.
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| "@backstage/backend-plugin-api": "workspace:^", | ||
| "@backstage/backend-tasks": "workspace:^", | ||
| "@backstage/catalog-model": "workspace:^", | ||
| "@backstage/catalog-model": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specified version 0.1.1 for @backstage/catalog-model is significantly outdated. Current Backstage packages typically use much higher version numbers (likely in the 1.x range). Replacing a workspace reference with such an old version will almost certainly cause compatibility issues with other Backstage components.
Consider using a more recent version that aligns with your other Backstage dependencies, or maintain the workspace reference if this is part of a monorepo setup. The same concern applies to the @backstage/plugin-catalog-node version.
| "@backstage/catalog-model": "0.1.1", | |
| "@backstage/catalog-model": "^1.4.0", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| "@backstage/config": "workspace:^", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/plugin-catalog-node": "workspace:^", | ||
| "@backstage/plugin-catalog-node": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing workspace references with fixed versions (0.1.1 for @backstage/catalog-model and 1.0.0 for @backstage/plugin-catalog-node) breaks the monorepo dependency management pattern used in Backstage.
Workspace references (workspace:^) ensure that compatible versions are used across the project and that local changes are immediately reflected. Fixed versions will:
- Prevent local development changes from propagating
- Potentially introduce version conflicts with other components
- Make it harder to maintain consistent dependency versions
Consider keeping the workspace references and instead updating the root dependencies to address the vulnerability. This maintains the monorepo integrity while still addressing the security issue.
| "@backstage/plugin-catalog-node": "1.0.0", | |
| "@backstage/plugin-catalog-node": "workspace:^", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Entelligence AI Vulnerability ScannerStatus: No security vulnerabilities found Your code passed our comprehensive security analysis. |
WalkthroughThis pull request updates the dependency management strategy for the catalog-backend-module-puppetdb plugin by replacing workspace protocol references with explicit version pinning. Two Backstage catalog-related dependencies are affected: Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant WS as Workspace Registry
participant NPM as NPM Registry
participant Plugin as catalog-backend-module-puppetdb
Dev->>PM: Update package.json dependencies
Note over Dev,PM: Pin catalog-model to 0.1.1<br/>Pin plugin-catalog-node to 1.0.0
Dev->>PM: Run install command
PM->>NPM: Fetch @backstage/catalog-model@0.1.1
NPM-->>PM: Return package
PM->>NPM: Fetch @backstage/plugin-catalog-node@1.0.0
NPM-->>PM: Return package
PM->>Plugin: Install dependencies
Plugin-->>PM: Dependencies installed
PM-->>Dev: Installation complete
Note over Plugin: Plugin now uses fixed versions<br/>instead of workspace references
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/catalog-backend-module-puppetdb/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-OCTOKITREQUESTERROR-8730854
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
Summary by Sourcery
Update package dependencies to fix a security vulnerability in the catalog backend module
Bug Fixes:
Enhancements:
EntelligenceAI PR Summary
This PR pins Backstage catalog dependencies to explicit versions in the catalog-backend-module-puppetdb plugin, moving away from workspace protocol references.
@backstage/catalog-modelfromworkspace:^to fixed version0.1.1@backstage/plugin-catalog-nodefromworkspace:^to fixed version1.0.0plugins/catalog-backend-module-puppetdb/package.json