Repository navigation
fix(editor): cancel toast work when the website editor closes - #4670
Merged
hellofrequencylab merged 1 commit intoNov 4, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The website editor left its 2.6-second toast callback active after unmount. That callback could run after the test browser was torn down and fail an otherwise passing CI test job; late async completions could also schedule a new toast after the editor closed.
The shell now cancels/resets its toast timer on cleanup and ignores toast-only work after unmount, resetting the mounted marker on effect setup for StrictMode. Existing messages, duration, replacement timing and save/publish/Vera requests stay unchanged.
Validation: 35 unchanged editor tests and five disposable actual-shell lifecycle cases pass. Pristine source fails the three teardown/late-completion cases while passing the two duration/replacement controls. ESLint, one-list, ADR, static backlog and diff checks pass. No protected tests/probes/pins or environment/timeouts changed. The new manual ledger row stays OPEN pending exact CI, READY preview and production verification.
Coordination: #4306 (comment). Root owns merging; auto-merge stays off.